Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media & Text alignment options #1546

Merged
merged 5 commits into from
Nov 8, 2019
Merged

Media & Text alignment options #1546

merged 5 commits into from
Nov 8, 2019

Conversation

lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Nov 6, 2019 •
edited
Loading

Fixes #1312
Ref to gutenberg: WordPress/gutenberg#18300

To test:

  1. Run the app
  2. Play with Media & Text alignments options using these buttons:

image

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@lukewalczak lukewalczak changed the title Align Media & Text options Media & Text alignment options Nov 6, 2019
@lukewalczak lukewalczak mentioned this pull request Nov 6, 2019
Merged
5 tasks
@lukewalczak lukewalczak self-assigned this Nov 6, 2019
@lukewalczak lukewalczak marked this pull request as ready for review November 7, 2019 08:51
pinarol
pinarol approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as described in the child PR. Let's revert the initial-html and :shipit:

@lukewalczak lukewalczak merged commit 63c882d into develop Nov 8, 2019
@lukewalczak lukewalczak deleted the callstack/rnmobile/alignment-media-text branch November 8, 2019 13:33
This was referenced Nov 11, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees

@lukewalczak lukewalczak

Labels
bugfix [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Media & Text - Alignment
2 participants
@lukewalczak @pinarol