Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Media & Text alignment options #18300

Merged
merged 4 commits into from
Nov 8, 2019
Merged

[RNMobile] Media & Text alignment options #18300

merged 4 commits into from
Nov 8, 2019

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Nov 6, 2019 •
edited
Loading

Fixes: wordpress-mobile/gutenberg-mobile#1312
Ref to gb-mobile: wordpress-mobile/gutenberg-mobile#1546

Description

Unblock and fix Media & Text alignment options

UPDATES:

  • Set center alignment by default

How has this been tested?

  1. Run the app
  2. Play with Media & Text alignments options using these buttons:

image

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@lukewalczak lukewalczak mentioned this pull request Nov 6, 2019
Merged
1 task
@lukewalczak lukewalczak added [Status] In Progress Tracking issues with work in progress [Block] Media & Text Affects the Media & Text Block Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Nov 6, 2019
@lukewalczak lukewalczak removed the [Status] In Progress Tracking issues with work in progress label Nov 7, 2019
@lukewalczak lukewalczak marked this pull request as ready for review November 7, 2019 08:51
@lukewalczak lukewalczak mentioned this pull request Nov 8, 2019
Closed
pinarol
pinarol approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good. 🎉

I tested on both WPiOS, WPAndroid. Alignment buttons work as expected.

I also couldn't repro this issue, on this branch, that seems fixed as well.

Let's :shipit:

@lukewalczak lukewalczak merged commit 2c3310f into master Nov 8, 2019
@lukewalczak lukewalczak deleted the rnmobile/alignment-media-text branch November 8, 2019 13:13
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
@hypest hypest mentioned this pull request Nov 11, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees
No one assigned
Labels
[Block] Media & Text Affects the Media & Text Block Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 6.9
Development

Successfully merging this pull request may close these issues.

Media & Text - Alignment
3 participants
@lukewalczak @pinarol @youknowriad