This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add/attributes filter count display toggle #9833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
block: filter by attribute
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +107 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
Thanks for working on this! Also, I noticed that it is necessary to add the deprecation even if we just change the value of an attribute because we still save the block attributes in the I'm unaware of a specific reason why we are doing it, so I think this is an excellent chance to refactor this (maybe in a follow-up PR). What do you think? |
|
Hi @gigitux I've refactored to remove the attributes being saved to HTML. Please let me know if this is correct and if I need to make any additional changes. |
gigitux
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
LGTM! Thanks for working on the feedback 🙇 I noticed that the Product Rating Preview isn't correct in a specific condition: If the store doesn't have any ratings, the block displays a preview with "fake data" and it shows the product counter even if it is set to off:
Should we open an issue and fix it?
Furthermore, could you open another issue about the Active Filters block that store the attributes in the HTML?
gigitux
force-pushed
the
add/attributes-filter-count-display-toggle
branch
from
75b47fc to
ff2deac
Compare
This was referenced Jun 22, 2023
7 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9298
This PR changes the default setting for
Display product countfromtruetofalseper discussion in the issue above.Testing
User Facing Testing
Click "Add New".
Filter by Attributes,Filter by Stock,Filter by Rating, andProducts (beta).WooCommerce Visibility
Performance Impact
Changelog