-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.18 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my only though is whether it would make sense to add some tests for the migration code itself. Ie, keeping the old fixtures and making sure they update to the new block markup. What do you think?
In any case, I don't think it's a blocker for this PR, so approving.
I've added the skip-changelog label as this PR should not surface in next week's release changelog |
This PR updates the testing fixtures to remove the data attributes from HTML to follow suit the following PRs:
Testing
User Facing Testing
Changelog