This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix filter count display toggle #10096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: bug
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
gigitux
requested review from
alexflorisca,
opr and
thealexandrelara
and removed request for
nefeline
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -37 B (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
thealexandrelara
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Thank you for working on this @gigitux. I noticed that the counts was being shown for the Rating filter, and that there was a change missing in the rating-filter/utils.ts file so I commited this change and now it seems to be working correctly.
I'm approving this PR! ✅
|
@thealexandrelara Thanks for fixing the rating-filter! |
opr
added
the
release: cherry-pick
opr
pushed a commit
that referenced
this pull request
Jul 5, 2023
* fix save method * improve check * Only display counts if showCounts is true --------- Co-authored-by: Alexandre Lara <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #9833. After the last refactor, a regression has been introduced. The counter was displayed/hidden correctly based on the toggle on the editor side. Instead, the counter was always visible on the frontend side.
When the
showCountsis false, it isn't saved as an attribute. So I changed the check in theutils.ts.Also, I improved the
savemethod since it isn't necessary anymore to use the inner HTML.Testing
Automated Tests
User Facing Testing
release/10.5.0branch, add post/page, and test the following blocks Filter by Attributes, Filter by Stock and Filter by Rating along with Products (beta) block. Just leave all default settings and publish post/page.Ensure you can toggle Display product count and it will hide/show the product counts in editor and frontend.