Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Active Filters saving data attributes in HTML #9959

Closed
roykho opened this issue Jun 22, 2023 · 0 comments · Fixed by #10047
Closed

Active Filters saving data attributes in HTML #9959

roykho opened this issue Jun 22, 2023 · 0 comments · Fixed by #10047
Assignees
@roykho
Labels
block: active filters Issues related to the Active Filters block. type: enhancement The issue is a request for an enhancement.

Comments

@roykho
Copy link
Member

roykho commented Jun 22, 2023

The Active Filters block currently saves the attributes data into the HTML seen here https://github.com/woocommerce/woocommerce-blocks/blob/trunk/assets/js/blocks/active-filters/index.tsx#L46

Since these attributes data is already handled by Gutenberg we don't need to do that. This issue is to remove those as seen done in this PR
@roykho roykho added type: enhancement The issue is a request for an enhancement. block: active filters Issues related to the Active Filters block. labels Jun 22, 2023
@roykho roykho changed the title Active Filters Active Filters saving data attributes in HTML Jun 22, 2023
@roykho roykho self-assigned this Jun 29, 2023
@roykho roykho mentioned this issue Jun 30, 2023
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roykho roykho

Labels
block: active filters Issues related to the Active Filters block. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove attributes data from save function for active filters woocommerce/woocommerce-blocks
1 participant
@roykho