This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Use consistent and semantically correct HTML elements in the Cart and Checkout blocks #9065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: enhancement
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
nielslange
force-pushed
the
update/8976-consistent-semantically-correct-HTML-markup
branch
from
26a7e0e to
05bf111
Compare
|
Size Change: -217 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
nielslange
commented
Apr 17, 2023
| @@ -35,7 +35,6 @@ const OrderSummary = ( { | |||
| { __( 'Order summary', 'woo-gutenberg-products-block' ) } | |||
| </span> | |||
| } | |||
| titleTag="h2" | |||
There was a problem hiding this comment.
The issue description on #8976 states the following:
The title
Order summaryuses a<span>element instead of an<h2>element.
Given that this element will contain a few sub elements, I believe using a <div> is the better option here. Therefore, instead of changing titleTag="h2" to titleTag="span", I removed that part, as div is defined as the default titleTag.
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
tarunvijwani
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Thank you for working on it, @nielslange! It works as expected. 🎉
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Yeah! Thanks for your review, @tarunvijwani! 🙌 |
…nsistent-semantically-correct-HTML-markup
nielslange
deleted the
update/8976-consistent-semantically-correct-HTML-markup
branch
11 tasks
tarunvijwani
pushed a commit
that referenced
this pull request
Apr 21, 2023
* Dummy commit to open a PR * Revert the last change * Ensure Checkout block supports the theme-level global styles for `Colors » Buttons` (#8844) * Add GS support for button colors in Checkout block * Sync button hover effect with GB * Fix link margin/padding (#8908) * Replace <AddToCartButton /> with <ProductButton /> (#8914) * Add GS support for button typography in Checkout block (#8918) * Ensure Checkout block supports the theme-level global styles for Typography » Buttons (#8892) * Remove classname from cart image to avoid conflicts (#8898) Co-authored-by: Niels Lange <[email protected]> * Use consistent and semantically correct HTML elements in the Cart and Checkout blocks (#9065) * Allow button height to adjust * Ensure to display full width heading background * Inherit font style and font weight for headings * Inherit font style and font weight for textarea * Inherit font family and font weight for buttons --------- Co-authored-by: Niels Lange <[email protected]> Co-authored-by: Mike Jolley <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 05bf111
Summary
🚚🧹🎨
This pull request refactors the order summary heading components in the cart and checkout blocks, to improve their accessibility, semantics, and reusability. It removes the
Titlecomponent and thetitleTagprop, and uses simplespanelements instead of nested headings.Walkthrough
titleTagprop fromOrderSummarycomponent to simplify API and avoid nested headings (link)Titlecomponent withspanelement incart-order-summary-headingblock and edit components to align withOrderSummarychange and reduce bundle size (link, link, link, link, link)👨💼 Enhanced by @nielslange
Fixes #8976
Testing
User Facing Testing
CART TOTALSelement, with the CSS class.wc-block-cart__totals-title, is using a<span>instead of an<h2>.Order summaryelement, with the CSS class.wc-block-components-order-summary, is using a<div>instead of an<h2>.CART TOTALSelement, with the CSS class.wc-block-cart__totals-title, is using a<span>instead of an<h2>.Order summaryelement, with the CSS class.wc-block-components-order-summary, is using a<div>instead of an<h2>.WooCommerce Visibility