Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Use consistent and semantically correct HTML elements in the Cart and Checkout blocks #8976

Closed
Tracked by #8710
nielslange opened this issue Apr 6, 2023 · 1 comment
Assignees
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.

Comments

@nielslange
Copy link
Member

nielslange commented Apr 6, 2023

Note

Currently, similar looking elements in the Cart and the Checkout block, are using different HTML markup. This issue aims to use consistent and semantically correct HTML elements. This issue is part of #8710 and the result of pdFofs-SY-p2.

Steps to reproduce

  1. Add a test product to the cart.
  2. Go to the cart page.
  3. See that the titles PRODUCT and TOTAL use a <span> element, while the title CART TOTALS uses an <h2> element.
  4. Go to the checkout page.
  5. See that the title Order summary uses an <h2> element, while the titles Subtotal, Shipping, Tax and Total use a <span> element.

Expected outcome

  • The title CART TOTALS uses a <span> element instead of an <h2> element.
  • The title Order summary uses a <span> element instead of an <h2> element.
@nielslange
Copy link
Member Author

Closing this, as the issue had been fixed with #9065.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.
Projects
None yet
Development

No branches or pull requests

1 participant