This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Cross-Sells block: Replace <AddToCartButton /> with <ProductButton /> #8914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: enhancement
woocommercebot
requested review from
a team and
mikejolley
and removed request for
a team
…oduct-button-block
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -8.51 kB (-1%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
nielslange
changed the base branch from
trunk
to
add/global-style-for-cart-checkout
…ace-add-to-cart-block-with-product-button-block
|
Will you also be removing the block thats not in use, or is this used elsewhere? |
To remove the "Add to Cart" block, @kmanijak created woocommerce/woocommerce#44503. I'd keep this separate from this PR, as it requires in-depth testing. I also noticed that all E2E tests are failing currently. I briefly looked into this, but haven't had time to see what's causing this. What I noticed was that all E2E tests of the featured branch are also failing. |
mikejolley
approved these changes
Apr 3, 2023
…ace-add-to-cart-block-with-product-button-block
Thanks for your review, @mikejolley. It appears that the failing E2E tests were related to #8928. I just ran the failing E2E tests again, and all tests are passing now:
|
nielslange
deleted the
update/GS-replace-add-to-cart-block-with-product-button-block
branch
11 tasks
tarunvijwani
pushed a commit
that referenced
this pull request
Apr 21, 2023
* Dummy commit to open a PR * Revert the last change * Ensure Checkout block supports the theme-level global styles for `Colors » Buttons` (#8844) * Add GS support for button colors in Checkout block * Sync button hover effect with GB * Fix link margin/padding (#8908) * Replace <AddToCartButton /> with <ProductButton /> (#8914) * Add GS support for button typography in Checkout block (#8918) * Ensure Checkout block supports the theme-level global styles for Typography » Buttons (#8892) * Remove classname from cart image to avoid conflicts (#8898) Co-authored-by: Niels Lange <[email protected]> * Use consistent and semantically correct HTML elements in the Cart and Checkout blocks (#9065) * Allow button height to adjust * Ensure to display full width heading background * Inherit font style and font weight for headings * Inherit font style and font weight for textarea * Inherit font family and font weight for buttons --------- Co-authored-by: Niels Lange <[email protected]> Co-authored-by: Mike Jolley <[email protected]>
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8858
In woocommerce/woocommerce#44503, @kmanijak suggested removing the Add to Cart block as that block is experimental, hasn't been touched for 3 years and as there's a newer block. Currently, the Cross-Sells Block is still using the Add to Cart block. This issue aims to replace with within the Cross-Sells Products block.
Screenshots
Testing
Automated Tests
User Facing Testing
Select options,View productsandAdd to cartare visible.Proceed to Checkoutbutton.Select optionsbutton opens the corresponding product page.View productsbutton opens the corresponding product page.Add to cartbutton adds that Cross-sell product to the cart.WooCommerce Visibility
Changelog