This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add GS support for headings typography in Checkout block #8918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: enhancement
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +24 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
nielslange
changed the title
wavvves
approved these changes
Apr 3, 2023
…ort-for-headings-typography-in-checkout
|
Thanks for your review, @wavvves! |
nielslange
deleted the
update/GS-support-for-headings-typography-in-checkout
branch
11 tasks
tarunvijwani
pushed a commit
that referenced
this pull request
Apr 21, 2023
* Dummy commit to open a PR * Revert the last change * Ensure Checkout block supports the theme-level global styles for `Colors » Buttons` (#8844) * Add GS support for button colors in Checkout block * Sync button hover effect with GB * Fix link margin/padding (#8908) * Replace <AddToCartButton /> with <ProductButton /> (#8914) * Add GS support for button typography in Checkout block (#8918) * Ensure Checkout block supports the theme-level global styles for Typography » Buttons (#8892) * Remove classname from cart image to avoid conflicts (#8898) Co-authored-by: Niels Lange <[email protected]> * Use consistent and semantically correct HTML elements in the Cart and Checkout blocks (#9065) * Allow button height to adjust * Ensure to display full width heading background * Inherit font style and font weight for headings * Inherit font style and font weight for textarea * Inherit font family and font weight for buttons --------- Co-authored-by: Niels Lange <[email protected]> Co-authored-by: Mike Jolley <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8811
Currently, the Checkout block partially supports the default theme-level global styles for Typography » Headings. This issue aims to ensure that the Checkout block fully supports the default theme-level global styles.
Current support of Global Styles of various themes
I tested this with the following themes:
Below, I listed the current support of Global Styles:
Current support for Adventurer theme
These are the sections where this theme overwrites the Global Styles:
Current support for Beaumont theme
This theme does not overwrite any Global Styles.
Current support for Björk theme
These are the sections where this theme overwrites the Global Styles:
Current support for Twenty Twenty-Two theme
These are the sections where this theme overwrites the Global Styles:
Current support for Twenty Twenty-Three theme
These are the sections where this theme overwrites the Global Styles:
Screenshots
Testing
User Facing Testing
WP Admin » Settings » Reading.WP Admin » Apperance » Editor.Stylessidebar.Typography » Headingssettings.FONT,APPEARANCE,LINE HEIGHT,LETTER SPACINGandLETTER CASE.WooCommerce Visibility
Changelog