This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove unused Add to Cart product element #11948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
skip-changelog
woocommercebot
requested review from
a team and
samueljseay
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -82.5 kB (-5%) ✅ Total Size: 1.52 MB
ℹ️ View Unchanged
|
nielslange
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Thanks for working on this, @kmanijak. The changes look good. I've successfully smoke tested the PR, the build process works flawlessly and all E2E tests are passing. While checking our codebase, I could not spot any leftovers of the removed Add to Cart product element.
samueljseay
pushed a commit
that referenced
this pull request
Nov 28, 2023
* Remove unused Add to Cart product element * Remove entry about Product Add to Cart product element from MD file
14 tasks
Aljullu
added a commit
that referenced
this pull request
Dec 4, 2023
Aljullu
added a commit
that referenced
this pull request
Dec 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove unused legacy Add to Cart product element. Removed elements:
Fixes woocommerce/woocommerce#44503
Why
We can remove it because:
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
add-to-cartProductAddToCartScreenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog