Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge next to main #12551

Merged
merged 201 commits into from
Nov 28, 2024
Merged

feat: merge next to main #12551

merged 201 commits into from
Nov 28, 2024

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Nov 28, 2024

Changes

This PR merges next to main

Testing

The CI must pass

Docs

N/A

ematipico and others added 30 commits August 6, 2024 11:23
* fix(cli): hardcoded supported Node.js version

* Create chatty-teachers-sit.md

---------

Co-authored-by: Erika <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
* refactor: types

* feat: refactor types

* chore: organize imports

* fix: remaining references

* docs: types

* refactor: small changes

* chore: changeset
* Remove @astrojs/lit

This removes the Lit integration as an official integration. The reasons
for doing so in 5.0:

- Only 1% of Astro users use this integration.
- SSR support in Lit is at a lower-level of support due to be a Labs
project: https://lit.dev/docs/libraries/labs/, and has been in this
state since we added support a couple of years ago.
- The maintenance cost of fixing bugs in this integration is too high
given the low usage. Some PRs for upgrading Lit versions have taken
quite a long time. We can't justify the core team being responsible for
this going forward.
- There used to be community contributions to fix bugs but this has
fallen off for various reasons.

Given that, this PR removes the integration as one that is officially
supported by the Astro core team. Interested community members are
encouraged to fork the integration and continue the development in
another repository.

* Remove e2e tests and examples

* Update lockfile

* Remove ssr-lit.test.js

* Remove error for no client entrypoint

* Remove auto selection of the Lit renderer

* Remove lit package.json

* Remove lit fixture
* Remove functionPerRoute option

* Remove more code

* Remove unused test util

* Linting

* Update tests to reflect new structure

* Add a changeset

* Update plugin

* Remove unused import
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <[email protected]>
* feat: remove the squoosh image service

* fix: build

* chore: changeset
* fix(assets): Remove TLA by making compiledContent async

* fix: actually use the functions I just added lol

* chore: changeset
* Use GET and preload links on Server Islands

Use origin/next

Remove since

* Add test to verify large islands work

* Update based on feedback

* Merge conflict fixed

* Update test
* Remove legacy route prioritization

* oops

* Add a changeset

* Remove bad merge stuff
* feat: change default value of `checkOrigin`

* feedback

* feedback

* change `checkOrigin`
* [ci] release (alpha)

* Update packages/astro/CHANGELOG.md

Co-authored-by: Sarah Rainsberger <[email protected]>

* links to existing experimental docs instead of ones that don't exist yet!

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matthew Phillips <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
* feat: add `Astro.route`

* change logic and add test

* rebase

* rebase

* rename to `Astro.routePattern`

* chore: added more tests

* update test

* add leading slash
This deprecated Astro.glob, see the changeset for details.
astrobot-houston and others added 7 commits November 26, 2024 11:38
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: 84ce4be

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) docs pr semver: minor Change triggers a `minor` release labels Nov 28, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@ematipico ematipico changed the title Next feat: merge next to main Nov 28, 2024
@ematipico ematipico marked this pull request as ready for review November 28, 2024 10:45
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #12551 will improve performances by 27.65%

Comparing next (84ce4be) with main (65e50eb)

Summary

⚡ 4 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark main next Change
Rendering: streaming [false], .astro file 1.7 s 1.5 s +10.47%
Rendering: streaming [false], .mdx file 1.2 s 1 s +15.6%
Rendering: streaming [true], .md file 16.4 ms 12.8 ms +27.65%
Rendering: streaming [true], .mdx file 1,161 ms 944.7 ms +22.9%

@ematipico ematipico merged commit c50882d into main Nov 28, 2024
30 checks passed
@ematipico ematipico deleted the next branch November 28, 2024 11:12
@delucis delucis restored the next branch November 28, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions docs pr feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.