Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop node 21 support #12539

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Drop node 21 support #12539

merged 1 commit into from
Nov 27, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 27, 2024

Changes

Drop node 21 as it's an odd version, and node 22 is already active LTS.

I marked this as minor, not sure if it has to be a major since it's an odd version, but I'm fine either ways.

Testing

CI should pass

Docs

Maybe worth noting in the migration guide?

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 216de37

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release labels Nov 27, 2024
github-actions[bot]
github-actions bot previously requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@ematipico
Copy link
Member

LGTM

@bluwy bluwy merged commit 827093e into next Nov 27, 2024
13 checks passed
@bluwy bluwy deleted the drop-node-21 branch November 27, 2024 13:54
@astrobot-houston astrobot-houston mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

@matthewp matthewp matthewp approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluwy @ematipico @matthewp