Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate glob #11826

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Deprecate glob #11826

merged 1 commit into from
Aug 27, 2024

Conversation

matthewp
Copy link
Contributor

Changes

  • Marks Astro.glob as deprecated in the types.
  • Adds a runtime warning when used.

Testing

  • None needed, just a deprecation.
  • Since it's still supported we don't want to actually remove tests yet.

Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: e2e6847

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthewp matthewp mentioned this pull request Aug 23, 2024
Merged
@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review semver: major Change triggers a `major` release labels Aug 23, 2024
github-actions[bot]
github-actions bot previously requested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@matthewp matthewp changed the base branch from main to next August 23, 2024 16:14
@matthewp
Deprecate Astro.glob
e2e6847 
This deprecated Astro.glob, see the changeset for details.
@github-actions github-actions bot removed feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) labels Aug 23, 2024
@matthewp matthewp merged commit 7315050 into next Aug 27, 2024
14 checks passed
@matthewp matthewp deleted the deprecate-glob branch August 27, 2024 14:51
@astrobot-houston astrobot-houston mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review semver: major Change triggers a `major` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @bluwy