Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): hardcoded supported Node.js version #10742

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

ematipico
Copy link
Member

Changes

Follow up of the PR that updated the defined engines inside our package.json files

Testing

N/A

Docs

N/A

@ematipico ematipico requested a review from Princesseuh April 10, 2024 14:13
Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: b50ec6f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 10, 2024
bluwy
bluwy previously approved these changes Apr 10, 2024
@bluwy bluwy dismissed their stale review April 10, 2024 14:19

Only in Astro 5

@Princesseuh Princesseuh added the semver: major Change triggers a `major` release label Apr 10, 2024
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only do this for Astro 5! This is super breaking otherwise.

@ematipico
Copy link
Member Author

Ooops, sorry 😆 I misunderstood that

@ematipico ematipico marked this pull request as draft April 10, 2024 14:29
@Princesseuh Princesseuh changed the base branch from main to next August 5, 2024 18:32
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@Princesseuh Princesseuh marked this pull request as ready for review August 6, 2024 09:23
@Princesseuh Princesseuh merged commit b6fbdaa into next Aug 6, 2024
4 checks passed
@Princesseuh Princesseuh deleted the feat/follow-up-node-version branch August 6, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants