Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add single dot host test #37373

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

pad01g
Copy link
Contributor

@pad01g pad01g commented Dec 7, 2022

I suspect Chrome and Firefox are not following the standard when the host is a single-byte . character and its non-special URL.

non-special:
https://jsdom.github.io/whatwg-url/#url=aDovLy4=&base=YWJvdXQ6Ymxhbms=

special:
https://jsdom.github.io/whatwg-url/#url=aHR0cDovLy4=&base=YWJvdXQ6Ymxhbms=

Related to jsdom/whatwg-url#82, jsdom/whatwg-url#245

By following https://url.spec.whatwg.org/# I think standard and implementation in this repository is correct and . should be returned.

This repository currently only has special test case.

"Domains with empty labels",
{
"input": "http://./",
"base": "about:blank",
"href": "http://./",
"origin": "http://.",
"protocol": "http:",
"username": "",
"password": "",
"host": ".",
"hostname": ".",
"port": "",
"pathname": "/",
"search": "",
"hash": ""
},
{
"input": "http://../",
"base": "about:blank",
"href": "http://../",
"origin": "http://..",
"protocol": "http:",
"username": "",
"password": "",
"host": "..",
"hostname": "..",
"port": "",
"pathname": "/",
"search": "",
"hash": ""
},

This PR adds test case for non-special URL.

@domenic domenic enabled auto-merge (rebase) December 7, 2022 11:49
@foolip foolip disabled auto-merge December 16, 2022 15:00
@foolip foolip merged commit 91e72f5 into web-platform-tests:master Dec 16, 2022
@foolip
Copy link
Member

foolip commented Dec 16, 2022

Admin merged as requested by @annevk on Matrix.

@domenic domenic mentioned this pull request Dec 17, 2022
@pad01g pad01g deleted the add-single-dot-host-test branch December 19, 2022 00:04
@GPHemsley GPHemsley removed their assignment Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants