Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add single dot host test #245

Closed
wants to merge 1 commit into from

Conversation

pad01g
Copy link

@pad01g pad01g commented Dec 7, 2022

I suspect Chrome and Firefox are not following non-special URL when the host is a single-byte . character.

non-special:
https://jsdom.github.io/whatwg-url/#url=aDovLy4=&base=YWJvdXQ6Ymxhbms=

special:
https://jsdom.github.io/whatwg-url/#url=aHR0cDovLy4=&base=YWJvdXQ6Ymxhbms=

Related to #82

By following https://url.spec.whatwg.org/# I think standard and implementation in this repository is correct and . should be returned.

wpt repository only has special test case.
https://github.com/web-platform-tests/wpt/blob/2a64dae4641fbd61bd4257df460e188f425b492e/url/resources/urltestdata.json#L3889-L3919

@domenic
Copy link
Member

domenic commented Dec 7, 2022

Thanks! But can you add this to the web platform test repository instead, so that all implementations can benefit?

@pad01g
Copy link
Author

pad01g commented Dec 7, 2022

@domenic
Thanks, I'm not very familiar with where all the test case should be... I created PR for wpt repository. I will now close this PR.

@pad01g pad01g closed this Dec 7, 2022
@pad01g pad01g deleted the feature/add-single-dot-host-test branch December 7, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants