Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of "http://../" is not correct #82

Closed
wants to merge 1 commit into from
Closed

Conversation

Sebmaster
Copy link
Member

http://../ is parsed to http://0.0.0.0/

But must be parsed to http://../

It looks like IPv4 parser treats empty parts as 0, but https://url.spec.whatwg.org/#concept-ipv4-parser 6.1 says:

  1. If part is the empty string, return input.

@rmisev rmisev changed the title Parsing of "http://../" isn't correct Parsing of "http://../" is not correct Apr 3, 2017
@Sebmaster
Copy link
Member

@domenic Seems like this is not a recent spec change but has been here for a while so should be a patch release I think.

domenic pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 24, 2017
The test covers  https://url.spec.whatwg.org/#concept-ipv4-parser 6.1 item:
> 1. If part is the empty string, return input.

Related issue: jsdom/whatwg-url#82
@domenic domenic closed this in c3d6257 Apr 24, 2017
@Sebmaster Sebmaster deleted the fix/non-ip-ip branch April 24, 2017 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant