-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test how URL parser handles domains with empty labels #5397
Conversation
The test covers https://url.spec.whatwg.org/#concept-ipv4-parser 6.1 item: > 1. If part is the empty string, return input. Related issue: jsdom/whatwg-url#82
Notifying @Sebmaster, @annevk, @domenic, @mikewest, @rubys, @smola, @tomalec, @xiaojunwu, and @zcorpan. (Learn how reviewing works.) |
*This report has been truncated because the total content is 653732 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters). Firefox (nightly channel)Testing web-platform-tests at revision d4a8aaa All results7 tests ran/url/a-element-origin-xhtml.xhtml
/url/a-element-origin.html
|
Chrome (unstable channel)Testing web-platform-tests at revision d4a8aaa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @domenic merge in case he wants to first run these through whatwg-url.
Follow the spec of domainToASCII/domainToUnicode in whatwg, and synchronise WPT url test data. Refs: web-platform-tests/wpt#5397
Follow the spec of domainToASCII/domainToUnicode in whatwg, and synchronise WPT url test data. Refs: web-platform-tests/wpt#5397 PR-URL: #12707 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Follow the spec of domainToASCII/domainToUnicode in whatwg, and synchronise WPT url test data. Refs: web-platform-tests/wpt#5397
Follow the spec of domainToASCII/domainToUnicode in whatwg, and synchronise WPT url test data. Refs: web-platform-tests/wpt#5397 PR-URL: nodejs#12707 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
The test covers https://url.spec.whatwg.org/#concept-ipv4-parser 6.1 item:
Related issue: jsdom/whatwg-url#82
This change is