URL: fix invalid test #37557
Merged
URL: fix invalid test #37557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://url.spec.whatwg.org/#origin non-special URL has opaque origin, which is serialized as "null".
wpt-pr-bot
requested review from
annevk,
domenic,
GPHemsley,
mikewest and
TimothyGu
annevk
approved these changes
Dec 16, 2022
|
@foolip @sideshowbarker another one to admin merge. \o/ |
|
I'd like to investigate why the reference implementation gets this wrong; maybe hold off for a day or two. |
OK, if/when it’s ready merge — and if it still requires an admin merge then — please post another comment |
|
Ah, the broken test was introduced recently in #37373. My bad for approving it without doing a full test. OK @sideshowbarker, ready to admin-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://url.spec.whatwg.org/#origin non-special URL has opaque origin, which is serialized as "null".