Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix predicateGPUbyMemory: sort of devIDs reduce fragment gpu #2476

Conversation

WingkaiHo
Copy link

Signed-off-by: yougjiahe [email protected]

Traversal key of allocatableGPUs, devIDs are not in sequence. So it will make fragment gpu use.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 31, 2022
@WingkaiHo
Copy link
Author

WingkaiHo commented Aug 31, 2022

Sorry,last time forget sort devIDs before return. #2465

Copy link
Member

@shinytang6 shinytang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2022
Yikun and others added 14 commits September 16, 2022 16:43
Signed-off-by: Yikun Jiang <[email protected]>
Signed-off-by: jiangkaihua <[email protected]>
Signed-off-by: Xuzheng Chang <[email protected]>
…ation-more-than-one-gpu

fix gpu shareing predictor allocate more than one gpu for pod
…ap-loading-log

fix printing volcano-scheduler-configmap loading log;
Signed-off-by: kerthcet <[email protected]>
volcano-sh-bot and others added 17 commits October 20, 2022 14:56
Signed-off-by: kerthcet <[email protected]>
…k8s_v1.25

Volcano adapts to the k8s v1.25
cherry-pick: queue is not met even if oldDeserved and deserved are the same
…er/plugins/nodeorder;"

This reverts commit 6e0beac.

Signed-off-by: xilinxing <[email protected]>
Revert "merge volcano-sh#2506(add volume binding plugin) into scheduler/plugins/nodeorder;"
fix extender plugin http send wrong action name
Copy link
Contributor

@Thor-wl Thor-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WingkaiHo Hey, This PR looks to be OK for reviewers generally. Please rebase the fix to the latest master code. THX.

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@volcano-sh-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shinytang6, Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 24, 2022
@volcano-sh-bot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are not members of the volcano-sh org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • jiangkaihua
    • OWNERS

@volcano-sh-bot volcano-sh-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2022
@WingkaiHo WingkaiHo closed this Nov 24, 2022
@WingkaiHo WingkaiHo deleted the fix/predicateGPUbyMemory-return-ids-with-sequence branch November 24, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.