Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gpu shareing predictor allocate more than one gpu for pod #2475

Conversation

WingkaiHo
Copy link

@WingkaiHo WingkaiHo commented Aug 31, 2022

Signed-off-by: yougjiahe [email protected]

Predictor patch all suitable gpu ids which return from predicateGPUbyMemory to pod. But pod only need one of suitable id of gpu. Fix #2491

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 31, 2022
@WingkaiHo WingkaiHo changed the title gpu shareing predictor allocate more than one gpu for pod fix gpu shareing predictor allocate more than one gpu for pod Aug 31, 2022
@WingkaiHo
Copy link
Author

/assign @Thor-wl

Copy link
Member

@shinytang6 shinytang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shinytang6

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@volcano-sh-bot volcano-sh-bot merged commit dd99ea8 into volcano-sh:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volcano gpu-share plugin patch all suitalbe for pod
4 participants