fix unit test #2541
Merged
fix unit test #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/XS
waiterQ
force-pushed
the
fix-unit-test
branch
from
918738b
to
c795750
Compare
Signed-off-by: shaoqiu <[email protected]>
waiterQ
force-pushed
the
fix-unit-test
branch
from
c795750
to
d30d441
Compare
volcano-sh-bot
added
size/S
Thor-wl
approved these changes
Oct 24, 2022
| @@ -114,7 +114,7 @@ manifests: controller-gen | |||
|
|
|||
| unit-test: | |||
| go clean -testcache | |||
| go test -p 8 -race $$(find pkg -type f -name '*_test.go' | sed -r 's|/[^/]+$$||' | sort | uniq | sed "s|^|volcano.sh/volcano/|") | |||
| go test -p 8 -race $$(find pkg cmd -type f -name '*_test.go' | sed -r 's|/[^/]+$$||' | sort | uniq | sed "s|^|volcano.sh/volcano/|") | |||
There was a problem hiding this comment.
What's the background about the modifications?
There was a problem hiding this comment.
i see directory cmd have unit tests but not in use, so add it to unit-test in Makefile. i guess this is useful.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix unit test and add directory cmd in unit-test.