Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit test in cmd #2548

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fix unit test in cmd #2548

merged 1 commit into from
Oct 28, 2022

Conversation

kerthcet
Copy link
Member

Signed-off-by: kerthcet [email protected]

This is mainly because of #2541.

@kerthcet
Fix unit test in cmd
d3dff8c 
Signed-off-by: kerthcet <[email protected]>
@kerthcet
Copy link
Member Author

/kind bug

@volcano-sh-bot volcano-sh-bot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2022
@kerthcet
Copy link
Member Author

@Thor-wl Would you like to take a look?

@kerthcet
Copy link
Member Author

cc @william-wang

@kerthcet kerthcet mentioned this pull request Oct 28, 2022
Merged
hzxuzhonghu
hzxuzhonghu approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2022
@volcano-sh-bot volcano-sh-bot merged commit d3edde7 into volcano-sh:master Oct 28, 2022
@kerthcet kerthcet deleted the fix/cmd-unit-test branch October 28, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@merryzhou merryzhou Awaiting requested review from merryzhou

@wpeng102 wpeng102 Awaiting requested review from wpeng102

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kerthcet @volcano-sh-bot @hzxuzhonghu