[good first issue]enrich the unit-test for some package

[lowang-bh]

What would you like to be added:

There are many packages which don't have unit-test, such as:

• actions:

  • enqueue
  • backfill

• plugins:

  • gang
  • extender
  • overcommit
  • resourcequota
  • usage

• others, include some PRs:

UTs should include positive cases and reverse cases.

Why is this needed:

1. to avoid future changes impacting those function, and make code more strong

Benefits

1. you can familiar with the coding logic and get started with volcano

how to assign

assign only one package to yourself in each pr.

[lowang-bh]

/good first issue
/help wanted

[Subhasish-Behera]

/assign

[Subhasish-Behera]

@lowang-bh I would like to work on unit-tests for resourcequota

[rayoluo]

/assign

[rayoluo]

@lowang-bh I would like to work on the rest unit-tests

[hzq5477]

/assign

[lowang-bh]

@Subhasish-Behera @rayoluo Any updates on this issue?

[Subhasish-Behera]

@lowang-bh Just filed a PR for the resourcequota plugin. any feedback about the PR is welcome.

(cc @william-wang @Monokaix )

[lowang-bh]

Now we can use the base UT lib in #3343 to do the test.
Examples shows at PR #3340 #3341 #3342

[lowang-bh]

/good-first-issue

[volcano-sh-bot]

@lowang-bh:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[googs1025]

/assign

[googs1025]

@lowang-bh Hello, may I ask if this will allocate a specific part?

[lowang-bh]

@lowang-bh Hello, may I ask if this will allocate a specific part?

Welcome! You can work on those packages which have no UTs covered.

[MondayCha]

@googs1025 Hello, I'm currently looking into Issue #3075 and noticed that there's some overlap with current Issue regarding enqueue and backfill.

I was wondering if you're planning to address these actions in a future PR?

[googs1025]

@MondayCha Hi, hello, I am currently working on other packages. You can work on the action package.

[googs1025]

@MondayCha hi, Are you still working on this?

[MondayCha]

@MondayCha hi, Are you still working on this?

Sorry I haven't started yet. I'm still trying to understand the relevant code and might attempt it next week.

If you need to do enqueue and backfill, I will avoid it.

[lowang-bh]

/close

[JesseStutler]

Maybe need to refactor the current implementation of building pod, priorityclass, queue...? See here: #3075 (comment), current function like BuildPod's scalability is not so good, maybe to refactor implementation like in k8s repository in the future? https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/job/job_controller_test.go#L7791-L7821