add ut for enqueue action #3453
Conversation
volcano-sh-bot
added
the
kind/feature
volcano-sh-bot
added
the
size/L
|
Are there any cases about job can not enqueue? |
I added two type case, one: when pg is in running state, it will not join the queue, and the second one is when the specified queue does not exist, it will not join the queue. |
|
How about queue's allocation plus the incoming inqueue's resource will exceed queue's capacity? |
Yes, I thought about this case. I thought that these scenarios would be covered by the plugins test cases, so I did not add these cases. If needed, I can add it. |
volcano-sh-bot
added
the
needs-rebase
volcano-sh-bot
removed
the
needs-rebase
I advise to add some cases. |
done, i add the case "pggroup cannot enqueue because queue resources are less than podgroup MinResources" |
| action := New() | ||
| test.Run([]framework.Action{action}) | ||
| if err := test.CheckAll(i); err != nil { | ||
| t.Fatalf("case: (index: %v/name: %s), action: %s, error: %s", i, test.Name, action.Name(), err) |
There was a problem hiding this comment.
duplicate error message。 just need print the error which has included detail.
googs1025
force-pushed
the
add_enqueue_ut
branch
2 times, most recently
from
8ff3fbc
to
43c02b3
Compare
Signed-off-by: googs1025 <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lowang-bh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes ##3053
Special notes for your reviewer:
Does this PR introduce a user-facing change?