Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ut for pkg/controllers/job/plugins #3422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add ut for pkg/controllers/job/plugins #3422

wants to merge 1 commit into from

Conversation

googs1025
Copy link
Member

What type of PR is this?

unit test

What this PR does / why we need it:

  • add some unit test for pkg/controllers/job/plugins

Which issue(s) this PR fixes:

See more detail #3053 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shinytang6
You can assign the PR to them by writing /assign @shinytang6 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 17, 2024
@googs1025
Copy link
Member Author

image

@googs1025
Copy link
Member Author

I noticed that the test coverage in pkg/controllers can be improved. I will submit separate PRs to enhance this aspect.

@googs1025 googs1025 requested a review from Monokaix April 21, 2024 13:12
@googs1025
Copy link
Member Author

@hwdef @Monokaix /PTAL

@googs1025 googs1025 force-pushed the job_controller_plugin_ut branch 2 times, most recently from 9ad9b2a to 6f86cdb Compare April 29, 2024 07:55
@googs1025 googs1025 requested review from hwdef and lowang-bh May 7, 2024 02:05
@googs1025
Copy link
Member Author

@hwdef /PTAL thanks!

@googs1025 googs1025 requested a review from lowang-bh May 29, 2024 13:27
@googs1025
Copy link
Member Author

/assign @william-wang @Monokaix /PTAL thank for review

@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2024
@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2024
@googs1025 googs1025 mentioned this pull request Jun 4, 2024
Closed
hwdef
hwdef reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
@googs1025
Copy link
Member Author

/assign @Monokaix

lowang-bh
lowang-bh reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@lowang-bh lowang-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Monokaix
Copy link
Member

Monokaix commented Sep 4, 2024

It seems that most cases just check the err returned, and the specific logic is not covered, maybe we can improve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowang-bh lowang-bh lowang-bh left review comments

@hwdef hwdef hwdef left review comments

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@Monokaix Monokaix Awaiting requested review from Monokaix

At least 1 approving review is required to merge this pull request.

Assignees

@hwdef hwdef

@Monokaix Monokaix

@lowang-bh lowang-bh

Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@googs1025 @volcano-sh-bot @Monokaix @hwdef @lowang-bh