add S3 minimum part size defined by the user

[rvrangel]

Description

This adds a new parameter to allow the operator to specify a minimum part size for the S3 uploads.

Related Issue(s)

fixes #17175

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.39%. Comparing base (0b51839) to head (5994e0e).

Files with missing lines	Patch %	Lines
go/vt/mysqlctl/s3backupstorage/s3.go	95.83%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17171      +/-   ##
==========================================
+ Coverage   67.37%   67.39%   +0.01%     
==========================================
  Files        1573     1573              
  Lines      253113   253130      +17     
==========================================
+ Hits       170538   170592      +54     
+ Misses      82575    82538      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[mattlord]

LGTM. Just a couple of minor comments.

[mattlord]

Nit, but we use min in other existing flags so we can shorten this one as well. New flags should also use dashes rather than underscores as we want to transition to the latter for everything.

[mattlord]

Since this flag is part of a group... we may actually just want to keep them all uniform...

[rvrangel]

I can change it to min, but do let me know if the preferred is to use the dashes instead of underscores for it :)

[mattlord]

I would favor uniformity for this config group over moving to dashes, and move these all together.

[frouioui]

I would probably spell out what the default is and add a period to be consistent with other flags in the same group. The default shown by the helper is not very intuitive at first.

[rvrangel]

updated it :)

[mattlord]

Where do these min and max values come from? I would hope that there are consts we can use instead?

[rvrangel]

that's a great point. for the minimum, the SDK does define it, so we could use manager.MinUploadPartSize, but I don't see anything for the max. I will take a better look when I update the code for the flag change mentioned above, but we can at least change that one

[frouioui]

It would be better to use the constant provided by the SDK for the minimum. For the maximum there is none, it's fine to hardcode it but it should be a constant for clarity with a link to AWS's docs: https://docs.aws.amazon.com/AmazonS3/latest/userguide/qfacts.html

[rvrangel]

update it as well :)

[frouioui]

Hey @rvrangel the history of that Pull Request looks a bit broken. It needs to be rebased.