-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication Flaky Test fix: TestVtctldMigrateSharded #17182
Merged
rohit-nayak-ps
merged 2 commits into
vitessio:main
from
planetscale:rohit/flaky-test-migrate-sharded
Nov 11, 2024
Merged
VReplication Flaky Test fix: TestVtctldMigrateSharded #17182
rohit-nayak-ps
merged 2 commits into
vitessio:main
from
planetscale:rohit/flaky-test-migrate-sharded
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flaky when run with the other tests Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 8, 2024
rohit-nayak-ps
added
Component: VReplication
Type: Testing
Flakes
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Nov 8, 2024
rohit-nayak-ps
requested review from
GuptaManan100,
frouioui,
deepthi,
mattlord and
harshit-gangal
as code owners
November 8, 2024 15:01
mattlord
approved these changes
Nov 8, 2024
frouioui
approved these changes
Nov 11, 2024
rvrangel
pushed a commit
to rvrangel/vitess
that referenced
this pull request
Nov 21, 2024
Signed-off-by: Rohit Nayak <[email protected]>
rvrangel
pushed a commit
to rvrangel/vitess
that referenced
this pull request
Nov 21, 2024
Signed-off-by: Rohit Nayak <[email protected]> Signed-off-by: Renan Rangel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestVtctldMigrateSharded has been flaky for a while: https://app.launchableinc.com/organizations/vitess/workspaces/vitess-app/data/test-paths/class%3Dvreplication%23%23%23testcase%3DTestVtctldMigrateSharded. However it runs with no issues locally even with a significant number of runs.
Currently there are a lot of tests in the same test shard, which might account for the flakiness. We will try by moving TestMigrate(Un)Sharded to their own CI test 'shard' and monitor its flakiness.
Related Issue(s)
Checklist
Deployment Notes