Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go mod update #17227

Merged
merged 3 commits into from
Nov 14, 2024
Merged

go mod update #17227

merged 3 commits into from
Nov 14, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Nov 14, 2024

Description

This PR updates the go modules to latest version.

The upgrade has a fix in grpc-go library regarding the new grpc Buffer module.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Harshit Gangal <[email protected]>
Copy link
Contributor

vitess-bot bot commented Nov 14, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 14, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Nov 14, 2024
@harshit-gangal harshit-gangal added Component: General Changes throughout the code base Type: Dependencies Dependency updates Benchmark me Add label to PR to run benchmarks and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 14, 2024
Copy link
Contributor

vitess-bot bot commented Nov 14, 2024

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.40%. Comparing base (f6067e0) to head (0dde30d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17227      +/-   ##
==========================================
- Coverage   67.40%   67.40%   -0.01%     
==========================================
  Files        1570     1570              
  Lines      252903   252903              
==========================================
- Hits       170460   170458       -2     
- Misses      82443    82445       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal added Benchmark me Add label to PR to run benchmarks and removed Benchmark me Add label to PR to run benchmarks labels Nov 14, 2024
@harshit-gangal
Copy link
Member Author

@harshit-gangal harshit-gangal merged commit 3499a77 into vitessio:main Nov 14, 2024
101 checks passed
@harshit-gangal harshit-gangal deleted the gomod-upgrade branch November 14, 2024 10:14
rvrangel pushed a commit to rvrangel/vitess that referenced this pull request Nov 21, 2024
Signed-off-by: Harshit Gangal <[email protected]>
rvrangel pushed a commit to rvrangel/vitess that referenced this pull request Nov 21, 2024
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Renan Rangel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base Type: Dependencies Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants