-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Upgrade the Golang version to go1.23.3
#17199
Conversation
Signed-off-by: GitHub <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Hello! 👋 This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked. You can find the performance comparison on the arewefastyet website. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17199 +/- ##
==========================================
+ Coverage 67.32% 67.59% +0.27%
==========================================
Files 1569 1570 +1
Lines 252548 254054 +1506
==========================================
+ Hits 170023 171729 +1706
+ Misses 82525 82325 -200 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Florent Poinsard <[email protected]>
else if [ ${{ matrix.branch }} == "release-21.0" ]; then | ||
go run ./go/tools/go-upgrade/go-upgrade.go upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We changed how our workflows are written in v21.0
, meaning that in >= v21.0
the tool no longer need to update the workflow files, but in < v21.0
we still need to upgrade them, but we cannot modify CI workflows from a CI-triggered PR, so for all < v21.0
branches we use the --workflow-update=false
flag.
Signed-off-by: GitHub <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: frouioui <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>
Signed-off-by: GitHub <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: frouioui <[email protected]> Co-authored-by: Florent Poinsard <[email protected]> Signed-off-by: Renan Rangel <[email protected]>
This Pull Request bumps the Golang version to
go1.23.3
and the bootstrap version to38
.There are a few manual steps remaining:
cc @vitessio/release