Error handling fixes for `turbopack-node` and the HMR runtime #5189

ForsakenHarmony · 2023-06-02T17:31:41Z

Description

errors during module init are no longer ignored
non-Errors thrown inside node.js now display correctly

Bonus:

you can now debug the spawned node.js processes without recompiling via TURBOPACK_DEBUG_JS=operation

vercel · 2023-06-02T17:31:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-tailwind-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jun 7, 2023 7:08pm
examples-vite-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jun 7, 2023 7:08pm

9 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Jun 7, 2023 7:08pm
examples-cra-web	⬜️ Ignored (Inspect)	Visit Preview	Jun 7, 2023 7:08pm
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Jun 7, 2023 7:08pm
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	Jun 7, 2023 7:08pm
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Jun 7, 2023 7:08pm
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Jun 7, 2023 7:08pm
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Jun 7, 2023 7:08pm
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Jun 7, 2023 7:08pm
turbo-site	⬜️ Ignored (Inspect)	Visit Preview	Jun 7, 2023 7:08pm

github-actions · 2023-06-02T17:33:10Z

✅ This change can build next-swc

github-actions · 2023-06-02T17:44:09Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

github-actions · 2023-06-02T17:51:50Z

Linux Benchmark for `66ee3ea`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	9252.14µs ± 48.80µs	9234.41µs ± 51.46µs	-0.19%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8494.73µs ± 79.02µs	8471.73µs ± 145.05µs	-0.27%
bench_startup/Turbopack CSR/1000 modules	909.20ms ± 2.39ms	902.90ms ± 6.38ms	-0.69%

github-actions · 2023-06-05T19:46:49Z

Linux Benchmark for `61e7da1`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	896.58ms ± 2.24ms	884.58ms ± 3.04ms	-1.34%	-0.16%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	8341.89µs ± 36.66µs	8367.80µs ± 34.26µs	+0.31%
bench_hmr_to_eval/Turbopack CSR/1000 modules	7511.89µs ± 68.28µs	8136.00µs ± 674.08µs	+8.31%
bench_startup/Turbopack CSR/1000 modules	896.58ms ± 2.24ms	884.58ms ± 3.04ms	-1.34%	-0.16%

crates/turbopack-node/src/debug.rs

github-actions · 2023-06-05T21:51:15Z

Linux Benchmark for `8806d6c`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	9594.93µs ± 67.81µs	9628.42µs ± 86.51µs	+0.35%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8833.14µs ± 83.21µs	8744.03µs ± 61.15µs	-1.01%
bench_startup/Turbopack CSR/1000 modules	934.01ms ± 2.81ms	940.74ms ± 4.94ms	+0.72%

crates/turbopack-ecmascript-runtime/js/src/dev/runtime/base/runtime-base.ts

crates/turbopack-node/js/src/ipc/error.ts

alexkirsz · 2023-06-06T08:24:58Z

crates/turbopack-node/js/src/ipc/index.ts

@@ -133,9 +136,11 @@ function createIpc<TIncoming, TOutgoing>(
          ...structuredError(error),
        });
      } catch (err) {
+        console.error("failed to send error back to rust:", err);


This should only be logged in some kind of verbose/tracing mode, as I don't think it's very actionable from a user's perspective.

I added this because previously the error outputted was something like "unexpected EOF" so while it might not be actionable I thought it might be easier to understand and if we receive feedback easier to debug, can remove it again though

crates/turbopack-node/src/debug.rs

crates/turbopack-node/src/transforms/postcss.rs

crates/turbopack-node/src/render/node_api_source.rs

github-actions · 2023-06-07T18:52:42Z

Linux Benchmark for `6a402af`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	9589.03µs ± 67.70µs	9703.33µs ± 82.75µs	+1.19%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8608.67µs ± 53.46µs	9078.08µs ± 318.93µs	+5.45%
bench_startup/Turbopack CSR/1000 modules	932.44ms ± 0.83ms	927.71ms ± 2.74ms	-0.51%

github-actions · 2023-06-07T19:28:35Z

Linux Benchmark for `de987a9`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	9195.14µs ± 88.16µs	8795.36µs ± 61.32µs	-4.35%	-1.12%
bench_startup/Turbopack CSR/1000 modules	915.55ms ± 1.04ms	905.71ms ± 3.83ms	-1.08%	-0.01%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	9195.14µs ± 88.16µs	8795.36µs ± 61.32µs	-4.35%	-1.12%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8044.01µs ± 31.93µs	8094.71µs ± 172.32µs	+0.63%
bench_startup/Turbopack CSR/1000 modules	915.55ms ± 1.04ms	905.71ms ± 3.83ms	-1.08%	-0.01%

github-actions · 2023-06-07T20:07:31Z

Windows Benchmark for `de987a9`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	2977.93ms ± 12.07ms	3038.23ms ± 17.64ms	+2.02%	+0.03%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	15.51ms ± 0.01ms	15.50ms ± 0.01ms	-0.03%
bench_hmr_to_eval/Turbopack CSR/1000 modules	15.51ms ± 0.01ms	15.50ms ± 0.01ms	-0.08%
bench_startup/Turbopack CSR/1000 modules	2977.93ms ± 12.07ms	3038.23ms ± 17.64ms	+2.02%	+0.03%

### Turbopack Updates * vercel/turborepo#5156 * vercel/turborepo#5159 * vercel/turborepo#5162 * vercel/turborepo#5161 * vercel/turborepo#5174 * vercel/turborepo#5178 * vercel/turborepo#5121 * vercel/turborepo#5200 * vercel/turborepo#5207 * vercel/turborepo#5211 * vercel/turborepo#5210 * vercel/turborepo#5221 * vercel/turborepo#5218 * vercel/turborepo#5226 * vercel/turborepo#5139 * vercel/turborepo#5227 * vercel/turborepo#5189

…/turborepo#5189) ### Description - errors during module init are no longer ignored - non-Errors thrown inside node.js now display correctly Bonus: - you can now debug the spawned node.js processes without recompiling via `TURBOPACK_DEBUG_JS=operation`

turbo-orchestrator bot added the team: turbopack label Jun 2, 2023

ForsakenHarmony changed the title ~~Hrmny/web 1143 bubble up module init errors~~ Error handling fixes for turbopack-node and the HMR runtime Jun 2, 2023

vercel bot deployed to Preview – turbo-site June 2, 2023 17:32 View deployment

ForsakenHarmony force-pushed the hrmny/web-1143-bubble-up-module-init-errors branch from 7660790 to cdadd15 Compare June 5, 2023 19:07

vercel bot deployed to Preview – turbo-site June 5, 2023 19:08 View deployment

ForsakenHarmony marked this pull request as ready for review June 5, 2023 19:27

ForsakenHarmony requested a review from a team as a code owner June 5, 2023 19:27

jridgewell approved these changes Jun 5, 2023

View reviewed changes

crates/turbopack-node/src/debug.rs Outdated Show resolved Hide resolved

ForsakenHarmony force-pushed the hrmny/web-1143-bubble-up-module-init-errors branch from 1d73fd2 to dfd440d Compare June 5, 2023 21:31

alexkirsz reviewed Jun 6, 2023

View reviewed changes

alexkirsz approved these changes Jun 6, 2023

View reviewed changes

ForsakenHarmony force-pushed the hrmny/web-1143-bubble-up-module-init-errors branch from dfd440d to 516a886 Compare June 7, 2023 18:02

ForsakenHarmony requested a review from a team as a code owner June 7, 2023 18:02

ForsakenHarmony requested review from mehulkar and chris-olszewski June 7, 2023 18:02

turbo-orchestrator bot added area: ci team: turborepo labels Jun 7, 2023

ForsakenHarmony removed request for mehulkar and chris-olszewski June 7, 2023 18:04

ForsakenHarmony removed area: ci team: turborepo labels Jun 7, 2023

turbo-orchestrator bot added area: ci team: turborepo and removed area: ci labels Jun 7, 2023

ForsakenHarmony force-pushed the hrmny/web-1143-bubble-up-module-init-errors branch 2 times, most recently from 823e706 to e637d54 Compare June 7, 2023 18:32

ForsakenHarmony added 9 commits June 7, 2023 20:49

bubble up errors during module init instead of ignoring them

d90de4c

handle thrown non-Errors

98b28f7

allow debugging node.js processes without recompiling

d5cf587

remove unused imports

a22593e

fix meaning of comment

145c5da

update snapshots

1f584de

fix fmt

d896178

prettier and eslint fixes

8d7962a

add comment

740a614

update snapshots

30aa8da

ForsakenHarmony force-pushed the hrmny/web-1143-bubble-up-module-init-errors branch from e637d54 to 30aa8da Compare June 7, 2023 19:08

ForsakenHarmony merged commit 8f8a14c into main Jun 8, 2023

ForsakenHarmony deleted the hrmny/web-1143-bubble-up-module-init-errors branch June 8, 2023 00:03

ForsakenHarmony mentioned this pull request Jun 8, 2023

update turbopack vercel/next.js#50819

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error handling fixes for `turbopack-node` and the HMR runtime #5189

Error handling fixes for `turbopack-node` and the HMR runtime #5189

ForsakenHarmony commented Jun 2, 2023 •

edited

Loading

vercel bot commented Jun 2, 2023 •

edited

Loading

github-actions bot commented Jun 2, 2023

github-actions bot commented Jun 2, 2023 •

edited

Loading

github-actions bot commented Jun 2, 2023

github-actions bot commented Jun 5, 2023

github-actions bot commented Jun 5, 2023

alexkirsz Jun 6, 2023

ForsakenHarmony Jun 7, 2023

github-actions bot commented Jun 7, 2023

github-actions bot commented Jun 7, 2023

github-actions bot commented Jun 7, 2023

Error handling fixes for turbopack-node and the HMR runtime #5189

Error handling fixes for turbopack-node and the HMR runtime #5189

Conversation

ForsakenHarmony commented Jun 2, 2023 • edited Loading

Description

vercel bot commented Jun 2, 2023 • edited Loading

github-actions bot commented Jun 2, 2023

github-actions bot commented Jun 2, 2023 • edited Loading

⚠️ CI failed ⚠️

github-actions bot commented Jun 2, 2023

Linux Benchmark for 66ee3ea

github-actions bot commented Jun 5, 2023

Linux Benchmark for 61e7da1

github-actions bot commented Jun 5, 2023

Linux Benchmark for 8806d6c

alexkirsz Jun 6, 2023

Choose a reason for hiding this comment

ForsakenHarmony Jun 7, 2023

Choose a reason for hiding this comment

github-actions bot commented Jun 7, 2023

Linux Benchmark for 6a402af

github-actions bot commented Jun 7, 2023

Linux Benchmark for de987a9

github-actions bot commented Jun 7, 2023

Windows Benchmark for de987a9

Error handling fixes for `turbopack-node` and the HMR runtime #5189

Error handling fixes for `turbopack-node` and the HMR runtime #5189

ForsakenHarmony commented Jun 2, 2023 •

edited

Loading

vercel bot commented Jun 2, 2023 •

edited

Loading

github-actions bot commented Jun 2, 2023 •

edited

Loading

Linux Benchmark for `66ee3ea`

Linux Benchmark for `61e7da1`

Linux Benchmark for `8806d6c`

Linux Benchmark for `6a402af`

Linux Benchmark for `de987a9`

Windows Benchmark for `de987a9`