Prepare StaticAssetsContentSourceVc for basePath #5210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
✅ This change can build |
|
Linux Benchmark for 55f9459Click to view benchmark
|
ForsakenHarmony
approved these changes
Jun 5, 2023
jridgewell
added
the
pr: automerge
Linux Benchmark for 4803962Click to view benchmark
|
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Jun 8, 2023
### Turbopack Updates * vercel/turborepo#5156 * vercel/turborepo#5159 * vercel/turborepo#5162 * vercel/turborepo#5161 * vercel/turborepo#5174 * vercel/turborepo#5178 * vercel/turborepo#5121 * vercel/turborepo#5200 * vercel/turborepo#5207 * vercel/turborepo#5211 * vercel/turborepo#5210 * vercel/turborepo#5221 * vercel/turborepo#5218 * vercel/turborepo#5226 * vercel/turborepo#5139 * vercel/turborepo#5227 * vercel/turborepo#5189
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
### Turbopack Updates * vercel/turborepo#5156 * vercel/turborepo#5159 * vercel/turborepo#5162 * vercel/turborepo#5161 * vercel/turborepo#5174 * vercel/turborepo#5178 * vercel/turborepo#5121 * vercel/turborepo#5200 * vercel/turborepo#5207 * vercel/turborepo#5211 * vercel/turborepo#5210 * vercel/turborepo#5221 * vercel/turborepo#5218 * vercel/turborepo#5226 * vercel/turborepo#5139 * vercel/turborepo#5227 * vercel/turborepo#5189
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description This is part 1 of WEB-993 `basePath` support. The static assets (things served in the `/public` directory) can only serve requests that include the `basePath`, so we'll need to pass that in. In order to not completely invalidate the [source](https://github.com/vercel/next.js/blob/2b1f0d9351610b04d01638efed19252ca81d0023/packages/next-swc/crates/next-dev/src/lib.rs#L379-L380) function (and all the things that depend on cells created there, ie everything) every time the user edits the `next.config.js`, we'll need to accept a `StringVc`. This sets us up without breaking backwards compat, making this multi-PR adventure a little easier. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description This is part 1 of WEB-993 `basePath` support. The static assets (things served in the `/public` directory) can only serve requests that include the `basePath`, so we'll need to pass that in. In order to not completely invalidate the [source](https://github.com/vercel/next.js/blob/2b1f0d9351610b04d01638efed19252ca81d0023/packages/next-swc/crates/next-dev/src/lib.rs#L379-L380) function (and all the things that depend on cells created there, ie everything) every time the user edits the `next.config.js`, we'll need to accept a `StringVc`. This sets us up without breaking backwards compat, making this multi-PR adventure a little easier. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description This is part 1 of WEB-993 `basePath` support. The static assets (things served in the `/public` directory) can only serve requests that include the `basePath`, so we'll need to pass that in. In order to not completely invalidate the [source](https://github.com/vercel/next.js/blob/2b1f0d9351610b04d01638efed19252ca81d0023/packages/next-swc/crates/next-dev/src/lib.rs#L379-L380) function (and all the things that depend on cells created there, ie everything) every time the user edits the `next.config.js`, we'll need to accept a `StringVc`. This sets us up without breaking backwards compat, making this multi-PR adventure a little easier. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part 1 of WEB-993
basePathsupport. The static assets (things served in the/publicdirectory) can only serve requests that include thebasePath, so we'll need to pass that in. In order to not completely invalidate the source function (and all the things that depend on cells created there, ie everything) every time the user edits thenext.config.js, we'll need to accept aStringVc. This sets us up without breaking backwards compat, making this multi-PR adventure a little easier.Testing Instructions