Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Do not duplicate SWC transforms in the final binary #5200

Merged
merged 6 commits into from
Jun 5, 2023
Merged

refactor: Do not duplicate SWC transforms in the final binary #5200

merged 6 commits into from
Jun 5, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 5, 2023 •
edited
Loading

Description

This PR modifies generic instantiation to use &dyn Comments instead of SwcComments, to reduce binary size along with swc-project/swc#7489.

Testing Instructions

I'll post the binary size once swc-project/swc#7489 is merged.

  • Previous binary size: 133.4MiB
  • New binary size: 132.4MiB

Closes WEB-1148

@kdy1 kdy1 self-assigned this Jun 5, 2023
@vercel
Copy link

vercel bot commented Jun 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 5:02am
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 5:02am
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2023 5:02am
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2023 5:02am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2023 5:02am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2023 5:02am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2023 5:02am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2023 5:02am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2023 5:02am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2023 5:02am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2023 5:02am

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Linux Benchmark for 03efb63

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8278.90µs ± 68.71µs 8275.69µs ± 84.14µs -0.04%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7375.77µs ± 77.84µs 7631.92µs ± 250.38µs +3.47%
bench_startup/Turbopack CSR/1000 modules 913.83ms ± 0.87ms 914.34ms ± 5.34ms +0.06%

@kdy1 kdy1 marked this pull request as ready for review June 5, 2023 04:55
@kdy1 kdy1 requested review from a team as code owners June 5, 2023 04:55
@kdy1 kdy1 requested review from mehulkar and arlyon June 5, 2023 04:55
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Linux Benchmark for de139fd

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8774.43µs ± 58.18µs 8843.60µs ± 120.76µs +0.79%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7872.63µs ± 27.76µs 7977.33µs ± 298.70µs +1.33%
bench_startup/Turbopack CSR/1000 modules 914.36ms ± 1.84ms 923.63ms ± 10.90ms +1.01%

@kdy1 kdy1 added the pr: automerge Kodiak will merge these automatically after checks pass label Jun 5, 2023
@kodiakhq kodiakhq bot merged commit e8259c6 into main Jun 5, 2023
@kodiakhq kodiakhq bot deleted the kdy1/tr-generics branch June 5, 2023 06:17
mehulkar pushed a commit that referenced this pull request Jun 5, 2023
@kdy1 @mehulkar
refactor: Do not duplicate SWC transforms in the final binary (#5200)
9060b38 
### Description

This PR modifies generic instantiation to use `&dyn Comments` instead of
`SwcComments`, to reduce binary size along with
swc-project/swc#7489.

### Testing Instructions

I'll post the binary size once
swc-project/swc#7489 is merged.

---

 - Previous binary size: `133.4MiB`
 - New binary size: `132.4MiB`


---


Closes WEB-1148
@ForsakenHarmony ForsakenHarmony mentioned this pull request Jun 8, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jun 8, 2023
@ForsakenHarmony
update turbopack (#50819)
0d46361 
### Turbopack Updates
* vercel/turborepo#5156 
* vercel/turborepo#5159 
* vercel/turborepo#5162 
* vercel/turborepo#5161 

* vercel/turborepo#5174 
* vercel/turborepo#5178 
* vercel/turborepo#5121 
* vercel/turborepo#5200 
* vercel/turborepo#5207 
* vercel/turborepo#5211 
* vercel/turborepo#5210 
* vercel/turborepo#5221 
* vercel/turborepo#5218 
* vercel/turborepo#5226 
* vercel/turborepo#5139 
* vercel/turborepo#5227 
* vercel/turborepo#5189
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
@ForsakenHarmony @hydRAnger
update turbopack (vercel#50819)
fea2213 
### Turbopack Updates
* vercel/turborepo#5156 
* vercel/turborepo#5159 
* vercel/turborepo#5162 
* vercel/turborepo#5161 

* vercel/turborepo#5174 
* vercel/turborepo#5178 
* vercel/turborepo#5121 
* vercel/turborepo#5200 
* vercel/turborepo#5207 
* vercel/turborepo#5211 
* vercel/turborepo#5210 
* vercel/turborepo#5221 
* vercel/turborepo#5218 
* vercel/turborepo#5226 
* vercel/turborepo#5139 
* vercel/turborepo#5227 
* vercel/turborepo#5189
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@kdy1
refactor: Do not duplicate SWC transforms in the final binary (vercel…
5358ca6 
…/turborepo#5200)

### Description

This PR modifies generic instantiation to use `&dyn Comments` instead of
`SwcComments`, to reduce binary size along with
swc-project/swc#7489.

### Testing Instructions

I'll post the binary size once
swc-project/swc#7489 is merged.

---

 - Previous binary size: `133.4MiB`
 - New binary size: `132.4MiB`


---


Closes WEB-1148
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kdy1
refactor: Do not duplicate SWC transforms in the final binary (vercel…
6c23ac2 
…/turborepo#5200)

### Description

This PR modifies generic instantiation to use `&dyn Comments` instead of
`SwcComments`, to reduce binary size along with
swc-project/swc#7489.

### Testing Instructions

I'll post the binary size once
swc-project/swc#7489 is merged.

---

 - Previous binary size: `133.4MiB`
 - New binary size: `132.4MiB`


---


Closes WEB-1148
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@kdy1
refactor: Do not duplicate SWC transforms in the final binary (vercel…
52f7dbc 
…/turborepo#5200)

### Description

This PR modifies generic instantiation to use `&dyn Comments` instead of
`SwcComments`, to reduce binary size along with
swc-project/swc#7489.

### Testing Instructions

I'll post the binary size once
swc-project/swc#7489 is merged.

---

 - Previous binary size: `133.4MiB`
 - New binary size: `132.4MiB`


---


Closes WEB-1148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@mehulkar mehulkar Awaiting requested review from mehulkar mehulkar is a code owner automatically assigned from vercel/turbo-oss

@arlyon arlyon Awaiting requested review from arlyon arlyon is a code owner automatically assigned from vercel/turbo-oss

Assignees

@kdy1 kdy1

Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdy1 @sokra