Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(turbopack-image): fix build error #5207

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix(turbopack-image): fix build error #5207

merged 1 commit into from
Jun 5, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Jun 5, 2023

Description

enabling webp never actually able to build.

@kwonoj kwonoj requested a review from a team as a code owner June 5, 2023 17:10
@vercel
Copy link

vercel bot commented Jun 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 5:11pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jun 5, 2023 5:11pm
examples-cra-web ⬜️ Ignored (Inspect) Jun 5, 2023 5:11pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jun 5, 2023 5:11pm
examples-gatsby-web ⬜️ Ignored (Inspect) Jun 5, 2023 5:11pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jun 5, 2023 5:11pm
examples-native-web ⬜️ Ignored (Inspect) Jun 5, 2023 5:11pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Jun 5, 2023 5:11pm
examples-svelte-web ⬜️ Ignored (Inspect) Jun 5, 2023 5:11pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jun 5, 2023 5:11pm
examples-vite-web ⬜️ Ignored (Inspect) Jun 5, 2023 5:11pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

✅ This change can build next-swc

@kwonoj kwonoj added the pr: automerge Kodiak will merge these automatically after checks pass label Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kodiakhq kodiakhq bot merged commit c2f7a80 into main Jun 5, 2023
@kodiakhq kodiakhq bot deleted the fix-webp-build branch June 5, 2023 17:26
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Linux Benchmark for dd98210

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9007.78µs ± 30.12µs 9018.12µs ± 38.26µs +0.11%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8380.45µs ± 60.49µs 8360.44µs ± 159.75µs -0.24%
bench_startup/Turbopack CSR/1000 modules 924.78ms ± 4.02ms 939.89ms ± 5.22ms +1.63%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Windows Benchmark for dd98210

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 2645.73ms ± 7.73ms 2625.49ms ± 2.17ms -0.76% -0.02%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 15.50ms ± 0.02ms 15.95ms ± 0.23ms +2.92%
bench_hmr_to_eval/Turbopack CSR/1000 modules 15.47ms ± 0.02ms 15.49ms ± 0.03ms +0.09%
bench_startup/Turbopack CSR/1000 modules 2645.73ms ± 7.73ms 2625.49ms ± 2.17ms -0.76% -0.02%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

MacOS Benchmark for dd98210

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 25.21ms ± 0.13ms 29.36ms ± 0.83ms +16.45% +8.71%
bench_hmr_to_eval/Turbopack CSR/1000 modules 32.30ms ± 4.75ms 54.90ms ± 3.28ms +69.98% +15.65%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 25.21ms ± 0.13ms 29.36ms ± 0.83ms +16.45% +8.71%
bench_hmr_to_eval/Turbopack CSR/1000 modules 32.30ms ± 4.75ms 54.90ms ± 3.28ms +69.98% +15.65%
bench_startup/Turbopack CSR/1000 modules 3050.72ms ± 49.52ms 2967.56ms ± 72.32ms -2.73%

@ForsakenHarmony ForsakenHarmony mentioned this pull request Jun 8, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jun 8, 2023
@ForsakenHarmony
update turbopack (#50819)
0d46361 
### Turbopack Updates
* vercel/turborepo#5156 
* vercel/turborepo#5159 
* vercel/turborepo#5162 
* vercel/turborepo#5161 

* vercel/turborepo#5174 
* vercel/turborepo#5178 
* vercel/turborepo#5121 
* vercel/turborepo#5200 
* vercel/turborepo#5207 
* vercel/turborepo#5211 
* vercel/turborepo#5210 
* vercel/turborepo#5221 
* vercel/turborepo#5218 
* vercel/turborepo#5226 
* vercel/turborepo#5139 
* vercel/turborepo#5227 
* vercel/turborepo#5189
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
@ForsakenHarmony @hydRAnger
update turbopack (vercel#50819)
fea2213 
### Turbopack Updates
* vercel/turborepo#5156 
* vercel/turborepo#5159 
* vercel/turborepo#5162 
* vercel/turborepo#5161 

* vercel/turborepo#5174 
* vercel/turborepo#5178 
* vercel/turborepo#5121 
* vercel/turborepo#5200 
* vercel/turborepo#5207 
* vercel/turborepo#5211 
* vercel/turborepo#5210 
* vercel/turborepo#5221 
* vercel/turborepo#5218 
* vercel/turborepo#5226 
* vercel/turborepo#5139 
* vercel/turborepo#5227 
* vercel/turborepo#5189
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@kwonoj
fix(turbopack-image): fix build error (vercel/turborepo#5207)
00b2402 
### Description

enabling webp never actually able to build.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kwonoj
fix(turbopack-image): fix build error (vercel/turborepo#5207)
1165253 
### Description

enabling webp never actually able to build.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@kwonoj
fix(turbopack-image): fix build error (vercel/turborepo#5207)
39453b5 
### Description

enabling webp never actually able to build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwonoj @sokra