Backport PR #2542, #2538 to release/v1.7 #2543

hlts2 · 2024-07-26T03:17:09Z

Description

This PR contains the following changes.

Do full build at the timing of merging main and release branches.
The following error occurred in backport PR workflow. So I fixed the fetched GitHub info path.
https://github.com/vdaas/vald/actions/runs/10104382350/job/27943338799

Related Issue

Versions

Go Version: 1.22.5
Rust Version: 1.77.2
Docker Version: 20.10.8
Kubernetes Version: v1.30.3
NGT Version: 2.2.3

Checklist

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Summary by CodeRabbit

New Features
- Updated the environment variable for storing GitHub information to a standardized absolute path, enhancing accessibility.
- Simplified GitHub Actions workflows by removing specific path filters for push events, allowing for broader trigger conditions and potentially improving build efficiency.
Bug Fixes
- Resolved issues related to the accessibility of workflows by standardizing trigger conditions.
Chores
- Cleaned up multiple workflow configurations to eliminate unnecessary path specifications, streamlining processes across various workflows.

Signed-off-by: hlts2 <[email protected]>

coderabbitai · 2024-07-26T03:17:22Z

Walkthrough

The recent changes to the GitHub Actions workflow files involve two primary modifications: updating the path for the FETCHED_GITHUB_INFO_PATH environment variable to an absolute path and simplifying the triggering conditions for several workflows by removing specified paths under the push event. These alterations enhance the accessibility of fetched information and broaden the conditions under which workflows can be executed, potentially improving CI/CD efficiency.

Changes

Files Grouped by Changes	Change Summary
`.github/workflows/backport.yml`	Changed `FETCHED_GITHUB_INFO_PATH` from `github_info.json` to `/tmp/github_info.json`, standardizing file storage.
`.github/workflows/dockers-.yml` (except `dockers-index-`)	Removed specified paths under the `push` event triggers for various workflows, broadening trigger conditions for these workflows.
`.github/workflows/dockers-index-*`	Removed specified paths under the `push` event triggers, simplifying the workflow execution conditions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1edc786 and 513ba89.

Files selected for processing (21)

.github/workflows/backport.yml (1 hunks)
.github/workflows/dockers-agent-faiss-image.yml (1 hunks)
.github/workflows/dockers-agent-image.yml (1 hunks)
.github/workflows/dockers-agent-ngt-image.yml (1 hunks)
.github/workflows/dockers-agent-sidecar-image.yml (1 hunks)
.github/workflows/dockers-benchmark-job-image.yml (1 hunks)
.github/workflows/dockers-benchmark-operator-image.yaml (1 hunks)
.github/workflows/dockers-ci-container-image.yml (1 hunks)
.github/workflows/dockers-dev-container-image.yml (1 hunks)
.github/workflows/dockers-discoverer-k8s-image.yml (1 hunks)
.github/workflows/dockers-gateway-filter-image.yml (1 hunks)
.github/workflows/dockers-gateway-lb-image.yml (1 hunks)
.github/workflows/dockers-gateway-mirror-image.yaml (1 hunks)
.github/workflows/dockers-helm-operator-image.yml (1 hunks)
.github/workflows/dockers-index-correction.yml (1 hunks)
.github/workflows/dockers-index-creation.yml (1 hunks)
.github/workflows/dockers-index-operator.yml (1 hunks)
.github/workflows/dockers-index-save.yml (1 hunks)
.github/workflows/dockers-loadtest-image.yml (1 hunks)
.github/workflows/dockers-manager-index-image.yml (1 hunks)
.github/workflows/dockers-readreplica-rotate.yml (1 hunks)

Files skipped from review due to trivial changes (13)

.github/workflows/dockers-agent-image.yml
.github/workflows/dockers-agent-ngt-image.yml
.github/workflows/dockers-benchmark-job-image.yml
.github/workflows/dockers-dev-container-image.yml
.github/workflows/dockers-discoverer-k8s-image.yml
.github/workflows/dockers-gateway-filter-image.yml
.github/workflows/dockers-gateway-lb-image.yml
.github/workflows/dockers-gateway-mirror-image.yaml
.github/workflows/dockers-helm-operator-image.yml
.github/workflows/dockers-index-operator.yml
.github/workflows/dockers-index-save.yml
.github/workflows/dockers-loadtest-image.yml
.github/workflows/dockers-readreplica-rotate.yml

Additional comments not posted (8)

.github/workflows/dockers-ci-container-image.yml (1)

Line range hint 9-13:
Broadened triggering conditions for the workflow.

The removal of the paths section under the push event trigger broadens the conditions under which the workflow is triggered. This change may lead to more frequent executions of the workflow, which can be beneficial for ensuring comprehensive CI/CD coverage but may also increase resource usage.

Ensure that the increased frequency of workflow executions aligns with the project's CI/CD strategy and resource allocation.

.github/workflows/dockers-index-creation.yml (1)

Line range hint 9-11:
Narrowed triggering conditions for the workflow.

The removal of the paths section under the push event trigger narrows the conditions under which the workflow is triggered. This change may lead to less frequent executions of the workflow, which can reduce resource usage but may also result in missed opportunities for testing or building when changes occur in the previously listed paths.

Ensure that the reduced frequency of workflow executions aligns with the project's CI/CD strategy and testing requirements.

.github/workflows/dockers-index-correction.yml (1)

Line range hint 9-11:
Broadened triggering conditions for the workflow.

The removal of the paths section under the push event trigger broadens the conditions under which the workflow is triggered. This change may lead to more frequent executions of the workflow, which can be beneficial for ensuring comprehensive CI/CD coverage but may also increase resource usage.

Ensure that the increased frequency of workflow executions aligns with the project's CI/CD strategy and resource allocation.

.github/workflows/dockers-manager-index-image.yml (1)

Line range hint 10-39:
Impact of removing path filters on workflow triggers.

The removal of the paths section means that the workflow will now trigger on any change to the repository. This could lead to more frequent workflow runs, which may affect build times and resource usage. Ensure that this change aligns with the intended CI/CD strategy.

.github/workflows/dockers-agent-sidecar-image.yml (1)

Line range hint 10-39:
Impact of removing path filters on workflow triggers.

The removal of the path filters means that the workflow will now trigger on any change to the repository. This could lead to more frequent workflow runs, which may affect build times and resource usage. Ensure that this change aligns with the intended CI/CD strategy.

.github/workflows/dockers-agent-faiss-image.yml (1)

Line range hint 10-39:
Impact of removing path filters on workflow triggers.

The removal of the path filters means that the workflow will now trigger on any change to the repository. This could lead to more frequent workflow runs, which may affect build times and resource usage. Ensure that this change aligns with the intended CI/CD strategy.

.github/workflows/dockers-benchmark-operator-image.yaml (1)

Line range hint 14-28:
Verify the impact of narrowing the pull request trigger paths.

The pull_request section has been significantly reduced to only include .github/actions/docker-build/action.yaml. This change might reduce unnecessary workflow runs but could also miss important changes in other paths.

Can you confirm if this change is intended to reduce the scope of the workflow triggers? Are there any potential risks of missing important changes?

.github/workflows/backport.yml (1)

26-26: LGTM! Verify dependencies on the old path.

The change to an absolute path for FETCHED_GITHUB_INFO_PATH might improve the reliability of file access during the workflow execution.

However, please verify if there are any dependencies on the old path github_info.json that need to be updated.

vdaas-ci · 2024-07-26T03:34:32Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <[email protected]>

hlts2 added 2 commits July 26, 2024 12:13

fix: deleted unnecessary event path for docker build (#2538)

b48c2d3

Signed-off-by: hlts2 <[email protected]>

fix: fix info path location (#2542)

513ba89

Signed-off-by: hlts2 <[email protected]>

hlts2 self-assigned this Jul 26, 2024

hlts2 requested review from kmrmt, kpango and datelier July 26, 2024 03:17

kpango approved these changes Jul 26, 2024

View reviewed changes

coderabbitai bot reviewed Jul 26, 2024

View reviewed changes

coderabbitai bot approved these changes Jul 26, 2024

View reviewed changes

github-actions bot added type/ci size/XXXL priority/low labels Jul 26, 2024

hlts2 merged commit f31a1c6 into release/v1.7 Jul 26, 2024
125 checks passed

hlts2 deleted the fix/backport-workflow branch July 26, 2024 04:00

github-actions bot mentioned this pull request Aug 1, 2024

Monthly review time metrics report: 2024-07-01..2024-07-31 #2555

Closed

This was referenced Aug 1, 2024

[patch] Release v1.7.3 #2558

Closed

[patch] Release v1.7.13 #2561

Closed

[patch] Release v1.7.13 #2562

Closed

[patch] Release v1.7.13 #2569

Merged

This was referenced Oct 4, 2024

Backport PR #2670 to release/v1.7 for Refactor use Absolute path for Makefile #2673

Merged

[CI]: Increase the maximum limit of the gh pr list command #2683

Merged

coderabbitai bot mentioned this pull request Oct 11, 2024

🔖 🤖 Release v1.7.14 #2700

Merged

coderabbitai bot mentioned this pull request Nov 11, 2024

Backport PR #2733 to release/v1.7 for [BUGFIX] resolve agent GetGraphStatistics API double-free error problem #2738

Closed

2 tasks

coderabbitai bot mentioned this pull request Dec 13, 2024

Backport PR #2773 to release/v1.7 for Refactor github actions #2779

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport PR #2542, #2538 to release/v1.7 #2543

Backport PR #2542, #2538 to release/v1.7 #2543

hlts2 commented Jul 26, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 26, 2024 •

edited

Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

vdaas-ci commented Jul 26, 2024

Backport PR #2542, #2538 to release/v1.7 #2543

Backport PR #2542, #2538 to release/v1.7 #2543

Conversation

hlts2 commented Jul 26, 2024 • edited by coderabbitai bot Loading

Description

Related Issue

Versions

Checklist

Special notes for your reviewer

Summary by CodeRabbit

coderabbitai bot commented Jul 26, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

vdaas-ci commented Jul 26, 2024

hlts2 commented Jul 26, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 26, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)