Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Release v1.7.3 #2558

Closed
wants to merge 0 commits into from
Closed

[patch] Release v1.7.3 #2558

wants to merge 0 commits into from

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Aug 1, 2024

[patch] Release v1.7.13

Changelog

[Bugfix]

  • General Fixes

    1. fix: add checkout option #2545 (#2546)
    2. fix: make format #2534 (#2540)
    3. fix conflict bug #2537
    4. Bugfix that caused an error when argument has 3 or more nil arguments #2517 (#2520)
    5. Bugfix recreate benchmark job when operator reboot #2463 (#2464)
    6. Fix agent-faiss build failed #2418 (#2419)
    7. Fix the logic to determine docker image #2410 (#2420)
  • Backport and Release-Related

    1. Fix workflow trigger for backport pr creation #2471 (#2472)
    2. Fix output settings to determine-docker-image-tag action and release branch build tag name #2423 (#2425)
  • E2E and Index

    1. Fix e2e for read replica and add e2e for index operator #2455 (#2459)
    2. Fix index job logic to pass DNS A record #2438 (#2448)
  • Documentation and Other

    1. fix: typo of execution rule #2426 (#2427)
    2. 📝 Fix typo of file name #2413 (#2415)

[Enhancement]

  • General Improvements

    1. Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization #2549 (#2557)
    2. Implement ngt Statistics API #2539 (#2547)
    3. refactor index manager service add index service API to expose index informations #2525 (#2532)
  • API and Logic Changes

    1. Change default image tag from latest to nightly #2516 (#2518)
    2. update large top-K ratio handling logic #2509 (#2511)
    3. add inner product distance type for ngt #2454 (#2458)
    4. Implement index operator logic for read replica rotation #2444 (#2456)
  • Performance and Optimization

    1. update deps & add validation for Flush API when agent is Read Only #2433 (#2436)
    2. Add index-operator template implementation #2375 (#2424)
  • Testing and Metrics

    1. Implement client metrics interceptor for continuous benchmark job #2477 (#2480)
    2. Add tests for index information export #2412 (#2414)

[CI]

  1. [create-pull-request] automated change #2552 (#2556)
  2. Add workflow to check git conflict for backport PR #2548 (#2550)
  3. [CI] Add workflow to synchronize ubuntu base image #2526 (#2527)
  4. Automatically add backport main label for release-pr #2473 (#2475)

[Backport]

  1. Backport PR Fix info path location #2542, Deleted unnecessary event path for docker build #2538 to release/v1.7 #2543
  2. Backport docs updates to release/v1.7 #2521
  3. Backport Flush API #2434

[Documentation]

  1. capitalize faq #2512 (#2522)
  2. add faiss in values.yaml & valdrelease.yaml #2514 (#2519)
  3. add read replica and rotator docs #2497 (#2499)
  4. Update continuous benchmark docs #2485 (#2486)
  5. docs: add hrichiksite as a contributor for doc #2441 (#2442)

[Other]

  1. Add base of benchmark operator dashboard #2430 (#2453)
  2. Add client metrics panels for continuous benchmark job #2481 (#2483)
  3. Add unit tests for index operator #2460 (#2461)
  4. add reviewer guideline #2507 (#2508)
  5. Sync release/v1.7 to main #2495
  6. Add snapshot timestamp annotations to read replica agent #2428 (#2443)
  7. Update build rule for nightly image #2421 (#2422)

Versions

  • Vald Version: v1.7.12
  • Go Version: v1.22.5
  • Rust Version: v1.80.0
  • Docker Version: v27.1.1
  • Kubernetes Version: v1.30.3
  • Helm Version: v3.15.3
  • NGT Version: v2.2.4
  • Faiss Version: v1.8.0

@kpango kpango changed the base branch from main to release/v1.7 August 1, 2024 09:10
Copy link
Contributor

coderabbitai bot commented Aug 1, 2024

Walkthrough

Walkthrough

The changes primarily involve formatting and structural improvements to the documentation of the Flush RPC method. Enhancements include better alignment of tables, specifically the fields related to Object.Info_Index_Count, and the removal of unnecessary newlines. These modifications aim to improve the clarity and readability of the documentation without affecting the functionality of the RPC method.

Changes

File Path Change Summary
docs/api/flush.md Formatting adjustments, including table alignment and removal of an extraneous newline for improved clarity.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Server
    User->>Server: Request Flush
    Server-->>User: Acknowledge Request
    Server->>Database: Flush Data
    Database-->>Server: Confirm Flush
    Server-->>User: Return Success Response
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

deepsource-autofix bot added a commit that referenced this pull request Aug 1, 2024
This commit fixes the style issues introduced in 7118b42 according to the output
from Gofumpt and Prettier.

Details: #2558
Copy link

cloudflare-workers-and-pages bot commented Aug 1, 2024

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3756543
Status: ✅  Deploy successful!
Preview URL: https://a1e35037.vald.pages.dev
Branch Preview URL: https://pre-release-v1-7-patch.vald.pages.dev

View logs

docs/api/flush.md Outdated Show resolved Hide resolved
docs/api/flush.md Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5023899 and 3756543.

Files selected for processing (1)
  • docs/api/flush.md (2 hunks)
Additional context used
LanguageTool
docs/api/flush.md

[uncategorized] ~56-~56: The verb “is” doesn’t seem to fit in this context, “are” is probably more formally correct.
Context: ...te indicating whether vald-agent pods is present in the saving. | ### Status ...

(AI_HYDRA_LEO_CPT_IS_ARE)

Additional comments not posted (1)
docs/api/flush.md (1)

49-49: LGTM!

The line Object.Info_Index_Count is correctly formatted.

docs/api/flush.md Outdated Show resolved Hide resolved
@hlts2 hlts2 changed the title Pre release/v1.7/patch [patch] Release v1.7.3 Aug 1, 2024
@kpango kpango closed this Aug 2, 2024
@kpango kpango force-pushed the pre-release/v1.7/patch branch from 3756543 to 678e98d Compare August 2, 2024 06:32
@kpango kpango deleted the pre-release/v1.7/patch branch August 2, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant