refactor index manager service add index service API to expose index informations #2525

kpango · 2024-07-15T20:09:56Z

Description

The following modifications have been made to this PR.

Refactoring of IndexManager
- Integration of Index proto into Vald proto
- IndexInfo, IndexDetail, and GetTimestamp APIs are now available outside of Index manager
Automatic Dockerfile generation
- https://github.com/vdaas/vald/blob/refactor/manager-index/small-refactor/hack/docker/gen/main.go
Fixes to Typo
Expose IndexDetail API
Ingress Route optimization
- Added pass-through to LB when using MirrorGateway or FilterGateway as specific API processing is not needed
Add Formatter (crlfmt)
- https://github.com/cockroachdb/crlfmt
Detailing of internal info API
　- Add GoMaxProcs, CGOCall, GoroutineCount, RuntimeCPUCores

Related Issue

Versions

Go Version: 1.22.5
Rust Version: 1.77.2
Docker Version: 20.10.8
Kubernetes Version: v1.30.2
NGT Version: 2.2.2

Checklist

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

kpango · 2024-07-15T20:11:50Z

@coderabbitai please review

coderabbitai · 2024-07-15T20:12:03Z

@kpango, I will review the changes in the pull request.

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

kpango · 2024-07-15T20:14:36Z

@coderabbitai summary

kpango · 2024-07-15T20:14:39Z

@coderabbitai full review

coderabbitai · 2024-07-15T20:14:40Z

Actions performed

Summary regeneration triggered.

coderabbitai · 2024-07-15T20:14:44Z

Actions performed

Full review triggered.

vdaas-ci · 2024-07-15T20:15:20Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

coderabbitai · 2024-07-15T20:15:26Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

135 files out of 262 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…informations Signed-off-by: kpango <[email protected]>

github-actions · 2024-07-24T04:20:49Z

docs/user-guides/deployment.md

@@ -138,7 +138,7 @@ After create `values.yaml`, you can deploy by the following steps.
 When you need to update the configuration, you can update by following command with your new `values.yaml`.

 ```bash
-helm upgrate vald vald/vald --values <YOUR NEW VALUES FILE PATH>
+helm upgrade vald vald/vald --values <YOUR NEW VALUES FILE PATH>


[LanguageTool] _{reported by reviewdog 🐶}
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: vald
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC

github-actions · 2024-07-24T04:20:49Z

docs/user-guides/upgrade-cluster.md

@@ -27,7 +27,7 @@ You can edit your `values.yaml` and update your Vald cluster by following steps:

   ```bash
   helm upgrade <NAME> vald/vald --values <YOUR VALUES FILE PATH>
-   # e.g., helm upgrade vald vald/vald --values valeus.yaml
+   # e.g., helm upgrade vald vald/vald --values values.yaml


[LanguageTool] _{reported by reviewdog 🐶}
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: vald
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC

github-actions · 2024-07-24T04:20:49Z

docs/user-guides/upgrade-cluster.md

@@ -27,7 +27,7 @@ You can edit your `values.yaml` and update your Vald cluster by following steps:

   ```bash
   helm upgrade <NAME> vald/vald --values <YOUR VALUES FILE PATH>
-   # e.g., helm upgrade vald vald/vald --values valeus.yaml
+   # e.g., helm upgrade vald vald/vald --values values.yaml


[LanguageTool] _{reported by reviewdog 🐶}
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: values
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC

github-actions · 2024-07-24T04:20:49Z

docs/user-guides/upgrade-cluster.md

@@ -107,7 +107,7 @@ If there is major or minor upgrading, the chart structure may have changed.

   ```bash
   helm upgrade <NAME> vald/vald --values <YOUR VALUES FILE PATH>
-   # e.g., helm upgrade vald vald/vald --values valeus.yaml
+   # e.g., helm upgrade vald vald/vald --values values.yaml


[LanguageTool] _{reported by reviewdog 🐶}
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: vald
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC

github-actions · 2024-07-24T04:20:49Z

docs/user-guides/upgrade-cluster.md

@@ -107,7 +107,7 @@ If there is major or minor upgrading, the chart structure may have changed.

   ```bash
   helm upgrade <NAME> vald/vald --values <YOUR VALUES FILE PATH>
-   # e.g., helm upgrade vald vald/vald --values valeus.yaml
+   # e.g., helm upgrade vald vald/vald --values values.yaml


[LanguageTool] _{reported by reviewdog 🐶}
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: values
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC

hlts2

LGTM!

github-actions · 2024-07-24T04:26:34Z

internal/db/rdb/mysql/dbr/dbr_mock.go

@@ -62,7 +62,7 @@ type MockTx struct {
 	CommitFunc                  func() error
 	RollbackFunc                func() error
 	RollbackUnlessCommittedFunc func()
-	InsertBySqlFunc             func(query string, value ...interface{}) InsertStmt
+	InsertBySqlFunc             func(query string, value ...any) InsertStmt


🚫 [golangci] _{reported by reviewdog 🐶}
ST1003: struct field InsertBySqlFunc should be InsertBySQLFunc (stylecheck)

github-actions · 2024-07-24T04:26:34Z

internal/db/rdb/mysql/dbr/dbr_mock.go

@@ -80,7 +80,7 @@ func (t *MockTx) RollbackUnlessCommitted() {
 	t.RollbackUnlessCommittedFunc()
 }

-func (t *MockTx) InsertBySql(query string, value ...interface{}) InsertStmt {
+func (t *MockTx) InsertBySql(query string, value ...any) InsertStmt {


🚫 [golangci] _{reported by reviewdog 🐶}
ST1003: method InsertBySql should be InsertBySQL (stylecheck)

github-actions · 2024-07-24T04:26:34Z

internal/db/rdb/mysql/dbr/tx.go

@@ -51,7 +49,7 @@ func (t *tx) RollbackUnlessCommitted() {
 }

 // InsertBySql creates an InsertStmt from raw query.
-func (t *tx) InsertBySql(query string, value ...interface{}) InsertStmt {
+func (t *tx) InsertBySql(query string, value ...any) InsertStmt {


🚫 [golangci] _{reported by reviewdog 🐶}
ST1003: method InsertBySql should be InsertBySQL (stylecheck)

…informations (#2525) Signed-off-by: kpango <[email protected]>

…informations (#2525) (#2532) Signed-off-by: kpango <[email protected]> Co-authored-by: Yusuke Kato <[email protected]>

fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <[email protected]>

vdaas deleted a comment from coderabbitai bot Jul 15, 2024

refactor index manager service add index service API to expose index …

6ad94c0

…informations Signed-off-by: kpango <[email protected]>

kpango dismissed stale reviews from kmrmt and hlts2 via 6ad94c0 July 24, 2024 04:19

kpango force-pushed the refactor/manager-index/small-refactor branch from 547bfd4 to 6ad94c0 Compare July 24, 2024 04:19

github-actions bot added area/index/job/correction area/index/job/creation area/index/job/save area/index/job/readreplica labels Jul 24, 2024

github-actions bot reviewed Jul 24, 2024

View reviewed changes

github-actions bot removed area/index/job/correction area/index/job/creation area/index/job/save area/index/job/readreplica labels Jul 24, 2024

hlts2 self-requested a review July 24, 2024 04:25

hlts2 approved these changes Jul 24, 2024

View reviewed changes

github-actions bot reviewed Jul 24, 2024

View reviewed changes

kmrmt approved these changes Jul 24, 2024

View reviewed changes

datelier approved these changes Jul 24, 2024

View reviewed changes

datelier merged commit 76eb8d7 into main Jul 24, 2024
182 of 185 checks passed

datelier deleted the refactor/manager-index/small-refactor branch July 24, 2024 05:17

vdaas-ci pushed a commit that referenced this pull request Jul 24, 2024

refactor index manager service add index service API to expose index …

7e2518d

…informations (#2525) Signed-off-by: kpango <[email protected]>

hlts2 pushed a commit that referenced this pull request Jul 24, 2024

refactor index manager service add index service API to expose index …

5b90ac8

…informations (#2525) (#2532) Signed-off-by: kpango <[email protected]> Co-authored-by: Yusuke Kato <[email protected]>

github-actions bot mentioned this pull request Aug 1, 2024

Monthly review time metrics report: 2024-07-01..2024-07-31 #2555

Closed

This was referenced Aug 1, 2024

[patch] Release v1.7.3 #2558

Closed

[patch] Release v1.7.13 #2561

Closed

[patch] Release v1.7.13 #2562

Closed

[patch] Release v1.7.13 #2569

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor index manager service add index service API to expose index informations #2525

refactor index manager service add index service API to expose index informations #2525

kpango commented Jul 15, 2024 •

edited

Loading

kpango commented Jul 15, 2024

coderabbitai bot commented Jul 15, 2024

kpango commented Jul 15, 2024

kpango commented Jul 15, 2024

coderabbitai bot commented Jul 15, 2024

coderabbitai bot commented Jul 15, 2024

vdaas-ci commented Jul 15, 2024

coderabbitai bot commented Jul 15, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot Jul 24, 2024

github-actions bot Jul 24, 2024

github-actions bot Jul 24, 2024

github-actions bot Jul 24, 2024

github-actions bot Jul 24, 2024

hlts2 left a comment

github-actions bot Jul 24, 2024

github-actions bot Jul 24, 2024

github-actions bot Jul 24, 2024

refactor index manager service add index service API to expose index informations #2525

refactor index manager service add index service API to expose index informations #2525

Conversation

kpango commented Jul 15, 2024 • edited Loading

Description

Related Issue

Versions

Checklist

Special notes for your reviewer

kpango commented Jul 15, 2024

coderabbitai bot commented Jul 15, 2024

kpango commented Jul 15, 2024

kpango commented Jul 15, 2024

coderabbitai bot commented Jul 15, 2024

coderabbitai bot commented Jul 15, 2024

vdaas-ci commented Jul 15, 2024

coderabbitai bot commented Jul 15, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot Jul 24, 2024

Choose a reason for hiding this comment

github-actions bot Jul 24, 2024

Choose a reason for hiding this comment

github-actions bot Jul 24, 2024

Choose a reason for hiding this comment

github-actions bot Jul 24, 2024

Choose a reason for hiding this comment

github-actions bot Jul 24, 2024

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

github-actions bot Jul 24, 2024

Choose a reason for hiding this comment

github-actions bot Jul 24, 2024

Choose a reason for hiding this comment

github-actions bot Jul 24, 2024

Choose a reason for hiding this comment

kpango commented Jul 15, 2024 •

edited

Loading

coderabbitai bot commented Jul 15, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)