-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI]: Increase the maximum limit of the gh pr list command #2683
Conversation
Signed-off-by: hlts2 <[email protected]>
📝 WalkthroughWalkthroughThe pull request modifies the GitHub Actions workflow file Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[CHATOPS:HELP] ChatOps commands.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/backport.yaml (1)
53-55
: Approved: Increased PR fetch limit addresses the stated objective.The change from 10 to 100 in the
gh pr list
command's limit aligns with the PR's objective to increase the maximum limit for retrieving pull requests. This should help prevent failures in creating backport PRs due to insufficient PR information.However, consider the following:
- This change may increase the execution time of this step. Monitor the workflow's performance to ensure it doesn't significantly impact overall execution time.
- Be aware of potential GitHub API rate limit issues if this workflow runs frequently. Consider implementing rate limiting or caching mechanisms if needed.
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]> Co-authored-by: Hiroto Funakoshi <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Description
WHAT
I have Increased the maximum limit of the
gh pr list
command.WHY
Due to the low maximum limit, we couldn't retrieve the appropriate list of PRs, and the creation of the backport PR failed.
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit