Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose slotted input feature on field components #84

Closed
web-padawan opened this issue Nov 17, 2020 · 7 comments
Closed

Expose slotted input feature on field components #84

web-padawan opened this issue Nov 17, 2020 · 7 comments
Labels
a11y phase 1 First batch of accessibility fixes a11y Accessibility issue epic Big feature that has subtasks refactor Internal improvement requires new major This would be a breaking change v22

Comments

@web-padawan
Copy link
Member

web-padawan commented Nov 17, 2020

Because of Shadow DOM limitations, our components such as vaadin-text-field do not work well with autocomplete and some password managers because the <input> element is not in the light DOM by default.

We have undocumented slotted <input> feature in vaadin-text-field but not in other components.
At the same time we have the following components that support providing a custom input in a different way.

  • vaadin-combo-box-light
  • vaadin-date-picker-light

Let's discuss if we should implement slotted <input> support in all the components for consistency.

Related issues:

@mvysny
Copy link
Member

mvysny commented Nov 17, 2020

Also related to https://github.com/vaadin/vaadin-login/issues/96 since this effectively prevents you from placing Vaadin components into the Login component as custom content, since the username/password autocompletion will be disabled.

@web-padawan
Copy link
Member Author

Another related issue is https://github.com/vaadin/vaadin-core/issues/238 (field wrapper component).

@lkraav
Copy link
Contributor

lkraav commented Jan 19, 2021

In our case, slotted input feature is highly useful to integrate with existing GUI form-building backend mini-apps, for visual upgrade. Advanced and very expensive to reimplement JS-based features like conditional logic, multi-page etc can stay compatible with much less work - if they have input available for processing in light DOM.

@web-padawan
Copy link
Member Author

Prototype which we can use for inspiration: https://vaadin-form-prototype.glitch.me

@knoobie
Copy link
Contributor

knoobie commented Feb 26, 2021

@web-padawan Impressive work! Looks really promising!

@web-padawan
Copy link
Member Author

Thanks! The prototype is actually created by @jouni

@web-padawan
Copy link
Member Author

Closing as shipped in Vaadin 22 stable release that landed today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y phase 1 First batch of accessibility fixes a11y Accessibility issue epic Big feature that has subtasks refactor Internal improvement requires new major This would be a breaking change v22
Projects
None yet
Development

No branches or pull requests

4 participants