Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password-field base class using new mixins #2190

Closed
web-padawan opened this issue Jul 7, 2021 · 1 comment · Fixed by #2275
Closed

Add password-field base class using new mixins #2190

web-padawan opened this issue Jul 7, 2021 · 1 comment · Fixed by #2275
Assignees
Labels
a11y phase 1 First batch of accessibility fixes a11y Accessibility issue

Comments

@web-padawan
Copy link
Member

web-padawan commented Jul 7, 2021

Motivation

This is a pre-requisite for adding slotted <input> support to vaadin-password-field.

Depends on #2189 (needs text-field base class)
Part of #84

Proposed solution

  1. Create a new package @vaadin/password-field for a base class
  2. Add a class without defining a custom element - prototype
  3. Copy vaadin-password-field test suite, excluding tests covered by @vaadin/field-base mixins tests.

Related a11y issues

Reveal button not keyboard accessible (#120).

@web-padawan web-padawan added a11y Accessibility issue a11y phase 1 First batch of accessibility fixes labels Jul 7, 2021
@web-padawan web-padawan self-assigned this Jul 19, 2021
@knoobie
Copy link
Contributor

knoobie commented Jul 19, 2021

I have two notes about this from my test with our screen reader user in the past:

  • the aria-label of the button has to be customizable, otherwise it's another a11y/i18n problem
  • is it possible that the reveal button could work different depending how it was triggered?
    • Triggered by mouse: no change needed
    • Triggered by keyboard: the reveal/un-reveal mechanism should not be triggered by focus change, instead it should only be done manually by another click on the reveal button (Reasoning: screen reader have to change focus from the button to the input field, to read it.. this changes the type to password again and the screen reader can't read the value)

Edit: another idea; instead of changing the behavior depending on the trigger.. could the field value be announced like we did with the a11y announcer in vaadin avatar group?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y phase 1 First batch of accessibility fixes a11y Accessibility issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants