-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add password-field using slotted input #2275
Conversation
6c3b8ab
to
603b839
Compare
22bcb31
to
5af4088
Compare
When you reveal the password and then you focus on the input to change it, it goes back to the hidden state. Also focus out hides the password again. Both seems like a bad UX IMO. The first one is also an a11y issue since screen readers can't read the password which defeats the purpose of revealing it in the first place. nit: I think the reveal button also doesn't convey enough info when you toggle it, it's announced "selected" when you select it and nothing we you deselect it (VoiceOver). SR users might understand it, but we can also provide additional info like here. The snippet is from this blog post |
Some comments from the archived Tetralogical helpdesk channel in Slack where the prototype was discussed:
|
This is now fixed as mentioned here #2275 (comment), thanks to @sissbruecker and @fhdhsni for reporting. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
This PR adds
@vaadin/password-field
base class, Lumo and Material theme, and visual tests.Fixes #2190
Type of change