Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement date-picker using slotted input and new mixins #2204

Closed
web-padawan opened this issue Jul 7, 2021 · 0 comments · Fixed by #2532
Closed

Re-implement date-picker using slotted input and new mixins #2204

web-padawan opened this issue Jul 7, 2021 · 0 comments · Fixed by #2532
Assignees
@tomivirkki
Labels
a11y phase 1 First batch of accessibility fixes a11y Accessibility issue vaadin-date-picker

Comments

@web-padawan
Copy link
Member

web-padawan commented Jul 7, 2021 •
edited
Loading

Motivation

This is an issue for adding slotted <input> support to vaadin-date-picker.

Part of #84

Proposed solution

Update vaadin-date-picker to use new mixins.

Related a11y issues

Fixing role announcement (#167) and error message announcement (#147). Possibly also #1740 and #1745.
@web-padawan web-padawan added a11y Accessibility issue a11y phase 1 First batch of accessibility fixes labels Jul 7, 2021
@web-padawan web-padawan mentioned this issue Jul 7, 2021
Closed
@tomivirkki tomivirkki self-assigned this Sep 14, 2021
@web-padawan web-padawan changed the title Add date-picker base class using new mixins Re-implement date-picker using slotted input and new mixins Sep 15, 2021
@tomivirkki tomivirkki mentioned this issue Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomivirkki tomivirkki

Labels
a11y phase 1 First batch of accessibility fixes a11y Accessibility issue vaadin-date-picker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: update date-picker to use slotted input vaadin/web-components
2 participants
@tomivirkki @web-padawan