Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate vaadin-select to use new base class #2198

Closed
web-padawan opened this issue Jul 7, 2021 · 0 comments · Fixed by #2282
Closed

Migrate vaadin-select to use new base class #2198

web-padawan opened this issue Jul 7, 2021 · 0 comments · Fixed by #2282
Labels
a11y phase 1 First batch of accessibility fixes a11y Accessibility issue vaadin-select

Comments

@web-padawan
Copy link
Member

web-padawan commented Jul 7, 2021

Motivation

This is an issue for adding slotted <input> (or <button>) support to vaadin-select.

Depends on #2197
Part of #84

Proposed solution

  1. Add Lumo and Material theme to new package - Lumo prototype
  2. Add custom element definitions to vaadin-select base class located in the new package.
  3. Update vaadin-grid-pro-edit-select to depend on the new package and adjust its tests, if needed.
  4. Remove old implementation, keep the imports and make it load the new package.
  5. Once the new package is published, update Flow counterpart to use it instead of the old one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y phase 1 First batch of accessibility fixes a11y Accessibility issue vaadin-select
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant