Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate vaadin-text-field to use new base class #2220

Closed
web-padawan opened this issue Jul 8, 2021 · 0 comments · Fixed by #2620
Closed

Migrate vaadin-text-field to use new base class #2220

web-padawan opened this issue Jul 8, 2021 · 0 comments · Fixed by #2620
Assignees
Labels
a11y phase 1 First batch of accessibility fixes a11y Accessibility issue vaadin-text-field

Comments

@web-padawan
Copy link
Member

web-padawan commented Jul 8, 2021

Motivation

This is a final issue for adding slotted <input> support to vaadin-text-field.

It needs to be done after all the field components using vaadin-text-field are updated to not depend on it.

Part of #84

Proposed solution

  1. Add custom element definition to vaadin-text-field base class located in the new package.
  2. Move JSDoc annotations from the original element, check that the API docs are generated properly.
  3. Move test/typings folder and events type definitions from the original package.
  4. Update vaadin-grid-pro-edit-text-field to depend on the new package and adjust its tests, if needed.
  5. Optionally, create an extension for the text-field used by vaadin-grid-filter-column.
  6. Remove old implementation, keep the import and make it load the new package.
  7. Once the new package is published, update Flow counterpart to use it instead of the old one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y phase 1 First batch of accessibility fixes a11y Accessibility issue vaadin-text-field
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant