-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: move text-field to new base class #2620
Conversation
4ea300a
to
9162d5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs an update to readme, otherwise lgtm
There is a failure in Firefox which can be also reproduced locally with
Example: https://github.com/vaadin/web-components/pull/2620/checks?check_run_id=3707687559 Related tests were introduced by vaadin/vaadin-grid@7a07299 I have no idea if the tests still make sense. But apparently something is wrong with the new text-field. UPD: when updating |
The memory issue can be reproduced with the following test file: import { fixtureSync } from '@vaadin/testing-helpers';
import '@vaadin/text-field/vaadin-text-field.js';
for (let i = 0; i < 50; i++) {
describe('text-fields', () => {
it('should not run out of memory', () => {
fixtureSync('<vaadin-text-field></vaadin-text-field>'.repeat(10));
});
});
} |
77a80f4
to
1e48718
Compare
bd3c0a9
to
6c0f7b3
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version. |
Description
Fixes #2220
Type of change