3.1 cherry pick #8880
Merged
3.1 cherry pick #8880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use container (such as the latest Wilfdly) which forces to use significantly newer version of Jsoup than Vaadin depends to, this can cause a problem as deprecated method as been removed.
Also take into account that chunk modules may have submodules. Fixes #8493
Fixes vaadin/platform#1251 # Conflicts: # flow-server/src/main/java/com/vaadin/flow/server/frontend/NodeUpdater.java # flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeUpdaterTest.java
vaadin-bot
reviewed
Aug 24, 2020
| if (logger.isWarnEnabled()) { | ||
| logger.warn(String.join("\n", warnings)); | ||
| } | ||
| } else if (!info.isEmpty()) { | ||
| info.add(0, HEADER); | ||
| info.add(SEPARATOR); | ||
| if (logger.isInfoEnabled()) { |
There was a problem hiding this comment.
|
These commits haven't been picked from
|
* fixing error message when fails to load content of index.html * adding import * code enhancement * code enhancement and adding test * enhancement * simulate index-html absence by rename * adding space and assert rename file
* Add transmission semantic for URI attribute values Fixes #8813 * Add some comments, correct javadocs * Fix GWT tests * Use one magic method instead of another * Check the type of JsonValue before read it
* Avoid findIndex JS Array function. Fixes #8711 * Fix indentation
* Make a workaround for Spring boot run as jar Fixes #8705 * Add a unit test for implemented workaround. * Add forgotten resource * Improve variable name and add comments
|
Picked all the mentioned commits except |
mshabarov
previously approved these changes
Aug 24, 2020
vaadin-bot
reviewed
Aug 24, 2020
| * @throws UnsupportedOperationException | ||
| */ | ||
| @Override | ||
| public void setId(String id) { |
There was a problem hiding this comment.
|
SonarQube analysis reported 2 issues
Watch the comments in this conversation to review them. |
|
|
mshabarov
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T SQUASH