fixing error message when fails to load content of index.html (#8593) #8765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you so much for contributing this fix, @hichem-fazai! Could you please also add a unit test for |
|
@mshabarov ok it's my real pleasure :-) |
mshabarov
requested changes
Aug 13, 2020
flow-server/src/test/java/com/vaadin/flow/server/communication/IndexHtmlRequestHandlerTest.java
Outdated
Show resolved
Hide resolved
flow-server/src/test/java/com/vaadin/flow/server/communication/IndexHtmlRequestHandlerTest.java
Outdated
Show resolved
Hide resolved
flow-server/src/test/java/com/vaadin/flow/server/communication/IndexHtmlRequestHandlerTest.java
Outdated
Show resolved
Hide resolved
flow-server/src/test/java/com/vaadin/flow/server/communication/IndexHtmlRequestHandlerTest.java
Outdated
Show resolved
Hide resolved
mshabarov
requested changes
Aug 13, 2020
flow-server/src/main/java/com/vaadin/flow/server/communication/IndexHtmlRequestHandler.java
Outdated
Show resolved
Hide resolved
flow-server/src/test/java/com/vaadin/flow/server/communication/IndexHtmlRequestHandlerTest.java
Outdated
Show resolved
Hide resolved
mshabarov
requested changes
Aug 13, 2020
flow-server/src/test/java/com/vaadin/flow/server/communication/IndexHtmlRequestHandlerTest.java
Outdated
Show resolved
Hide resolved
mshabarov
approved these changes
Aug 13, 2020
|
Very happy to make my first commit to Vaadin :-) |
Good job, @hichem-fazai ! We appreciate your contribution. Thanks |
Merged
haijian-vaadin
pushed a commit
that referenced
this pull request
Aug 24, 2020
* fixing error message when fails to load content of index.html * adding import * code enhancement * code enhancement and adding test * enhancement * simulate index-html absence by rename * adding space and assert rename file
mshabarov
pushed a commit
that referenced
this pull request
Aug 24, 2020
* fixing error message when fails to load content of index.html * adding import * code enhancement * code enhancement and adding test * enhancement * simulate index-html absence by rename * adding space and assert rename file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have experienced the same issue vaadin/hilla#311
This PR is to add file separator to the error message.