Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terser Dependency cause Vaadin 14.1+ fail on Production mode #1251

Closed
ZheSun88 opened this issue Mar 31, 2020 · 1 comment · Fixed by vaadin/flow#8503
Closed

Terser Dependency cause Vaadin 14.1+ fail on Production mode #1251

ZheSun88 opened this issue Mar 31, 2020 · 1 comment · Fixed by vaadin/flow#8503

Comments

@ZheSun88
Copy link
Contributor

ZheSun88 commented Mar 31, 2020 •
edited
Loading

Issue:
After removing the package-lock.json, building Vaadin 14.1+ under production mode will cause client-side error, which leads to applications fail to load the UI.

Reason:
Due to terser/terser#627 in terser-4.6.9

Workaround:
for 14.1.21 or older 14.1 version and 15.0.0-15.0.2:

  • option 1: npm install [email protected] --save-dev after package.json is generated
  • option 2: adding "terser": "4.6.7", to package.json

we are going to fix this in the next platform release.
@pleku pleku mentioned this issue Apr 1, 2020
Open
@ZheSun88
Copy link
Contributor Author

ZheSun88 commented Apr 2, 2020

Terser 4.6.10 has been released and the mentioned issue has been fixed.
this ticket can be closed, better after removing the version pined in flow

@manolo manolo mentioned this issue Jun 5, 2020
Merged
caalador pushed a commit to vaadin/flow that referenced this issue Jun 8, 2020
@manolo
remove terser plugin from the default dependencies (#8503)
08862de 
Fixes vaadin/platform#1251
caalador pushed a commit to vaadin/flow that referenced this issue Jun 8, 2020
@manolo @caalador
remove terser plugin from the default dependencies (#8503)
9436b4c 
Fixes vaadin/platform#1251
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/server/frontend/NodeUpdater.java
#	flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeUpdaterTest.java
caalador pushed a commit to vaadin/flow that referenced this issue Jun 8, 2020
@manolo @caalador
remove terser plugin from the default dependencies (#8503)
3ccb59f 
Fixes vaadin/platform#1251

# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/server/frontend/NodeUpdater.java
#	flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeUpdaterTest.java
caalador pushed a commit to vaadin/flow that referenced this issue Jun 10, 2020
@manolo @caalador
remove terser plugin from the default dependencies (#8503)
87e9f12 
Fixes vaadin/platform#1251
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/server/frontend/NodeUpdater.java
#	flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeUpdaterTest.java
pleku pushed a commit to vaadin/flow that referenced this issue Jun 17, 2020
@manolo @pleku
remove terser plugin from the default dependencies (#8503)
d06af33 
Fixes vaadin/platform#1251
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/server/frontend/NodeUpdater.java
#	flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeUpdaterTest.java
mshabarov pushed a commit to vaadin/flow that referenced this issue Aug 24, 2020
@manolo @mshabarov
remove terser plugin from the default dependencies (#8503)
78014e4 
Fixes vaadin/platform#1251

# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/server/frontend/NodeUpdater.java
#	flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeUpdaterTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove terser plugin from the default dependencies vaadin/flow
1 participant
@ZheSun88