Skip to content

Commit

Permalink
remove terser plugin from the default dependencies (#8503)
Browse files Browse the repository at this point in the history
Fixes vaadin/platform#1251
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/server/frontend/NodeUpdater.java
#	flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeUpdaterTest.java
  • Loading branch information
manolo authored and caalador committed Jun 10, 2020
1 parent de7e21e commit 87e9f12
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,6 @@ static Map<String, String> getDefaultDevDependencies() {
defaults.put("webpack-merge", "4.2.2");
defaults.put("raw-loader", "3.1.0");

defaults.put("terser", "4.6.7");

// Forcing chokidar version for now until new babel version is available
// check out https://github.com/babel/babel/issues/11488
defaults.put("chokidar", "^3.4.0");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,14 +188,6 @@ public void updateDefaultDependencies_newerVersionsAreNotChanged()
.getObject(NodeUpdater.DEV_DEPENDENCIES).getString("webpack"));
}

@Test
public void assertTerserVersion() throws IOException {
final JsonObject packageJson = nodeUpdater.getPackageJson();
nodeUpdater.updateDefaultDependencies(packageJson);
Assert.assertEquals("4.6.7", packageJson
.getObject(NodeUpdater.DEV_DEPENDENCIES).getString("terser"));
}

private String getPolymerVersion(JsonObject object) {
JsonObject deps = object.get("dependencies");
String version = deps.getString("@polymer/polymer");
Expand Down

0 comments on commit 87e9f12

Please sign in to comment.